change: add account number and unit tests for govcloud #713
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurenyu
reviewed
Mar 20, 2019
| return "{}.dkr.ecr.{}.amazonaws.com".format(account_id, region_name) | ||
|
|
||
| domain_name = "c2s.ic.gov" if region_name == "us-iso-east-1" else "amazonaws.com" | ||
| return "{}.dkr.ecr.{}.{}".format(account_id, region_name, domain_name) |
There was a problem hiding this comment.
I usually apply the principle to use same quotes as nearby codes. Codes in this file use double quotes. Do you want to me to change all of them?
There was a problem hiding this comment.
Changed all of them.
src/sagemaker/fw_registry.py
Outdated
| @@ -80,7 +84,8 @@ def registry(region_name, framework=None): | |||
| """ | |||
| try: | |||
| account_id = image_registry_map[region_name][framework] | |||
| return "{}.dkr.ecr.{}.amazonaws.com".format(account_id, region_name) | |||
| domain_name = "c2s.ic.gov" if region_name == "us-iso-east-1" else "amazonaws.com" | |||
| return "{}.dkr.ecr.{}.{}".format(account_id, region_name, domain_name) | |||
There was a problem hiding this comment.
should we maybe refactor this logic somewhere?
There was a problem hiding this comment.
Updated. Wrapped in one function in utils.py
ChoiByungWook
approved these changes
Mar 21, 2019
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
mizanfiu
pushed a commit
to mizanfiu/sagemaker-python-sdk
that referenced
this pull request
Dec 13, 2022
Co-authored-by: Xinlu Tu <[email protected]> Co-authored-by: Xinlu Tu <[email protected]> @xinlutu2 feat: Close feature gaps between Python SageMaker SDK and CreateAutoMLJob API includes ENSEMBLING mode (aws#681) @xinlutu2 feature: add AutoMLStep for SageMaker Pipelines Workflows (aws#693) @xinlutu2 feature: add AutoMLStep integration test (aws#713)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Add account number for govcloud with unit tests
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.