Skip to content

fix: local data source relative path includes the first directory #702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 4, 2019
Merged

fix: local data source relative path includes the first directory #702

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
544e6bf
Fix local data source relative path
speg03 Mar 16, 2019
030788e
Merge branch 'master' into fix/local-relative-path
mvsusp Mar 19, 2019
a5e0bb9
Merge branch 'master' into fix/local-relative-path
yangaws Mar 24, 2019
72de66b
Merge branch 'master' into fix/local-relative-path
yangaws Mar 27, 2019
912e780
Merge branch 'master' into fix/local-relative-path
speg03 Mar 30, 2019
492d4a1
Merge branch 'master' into fix/local-relative-path
speg03 Apr 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/sagemaker/local/data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ def get_data_source_instance(data_source, sagemaker_session):
"""
parsed_uri = urlparse(data_source)
if parsed_uri.scheme == 'file':
return LocalFileDataSource(parsed_uri.path)
return LocalFileDataSource(parsed_uri.netloc + parsed_uri.path)
elif parsed_uri.scheme == 's3':
return S3DataSource(parsed_uri.netloc, parsed_uri.path, sagemaker_session)

Expand Down
4 changes: 4 additions & 0 deletions tests/unit/test_local_data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,10 @@ def test_get_data_source_instance_with_file(LocalFileDataSource, sagemaker_local
LocalFileDataSource.assert_called_with('/my/file')
assert data_source is not None

data_source = sagemaker.local.data.get_data_source_instance('file://relative/path', sagemaker_local_session)
LocalFileDataSource.assert_called_with('relative/path')
assert data_source is not None


@patch('sagemaker.local.data.S3DataSource')
def test_get_data_source_instance_with_s3(S3DataSource, sagemaker_local_session):
Expand Down