Skip to content

Migrate content from workflow and pytorch readmes into sphinx project #700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 19, 2019

Conversation

eslesar-aws
Copy link
Contributor

Issue #, if available:

Description of changes:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

  • [x ] I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • [x ] I have updated the changelog with a description of my changes (if appropriate)
  • [x ] I have updated any necessary documentation (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jesterhazy
Copy link
Contributor

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

@laurenyu laurenyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you update the PR title to capture that this is both the Workflow and PyTorch readmes?

CHANGELOG.rst Outdated
1.18.6dev
=========

* doc-fix: Move workflow and pytorch readme content into sphinx project
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

capitalize "PyTorch"

@eslesar-aws eslesar-aws changed the title Migrate workflow Migrate content from workflow and pytorch readmes into sphinx project Mar 15, 2019
@jesterhazy
Copy link
Contributor

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

CHANGELOG.rst Outdated
1.18.6dev
=========

* doc-fix: Move workflow and PyTorch readme content into sphinx project, fixed broken links in using_tensorflow.rst
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd make these into two bullet points:

* doc-fix: Move workflow and PyTorch readme content into sphinx project
* doc-fix: Fix broken links in ``using_tensorflow.rst``

@jesterhazy
Copy link
Contributor

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@laurenyu laurenyu merged commit f32abfa into aws:master Mar 19, 2019
@eslesar-aws eslesar-aws deleted the migrate-workflow branch April 23, 2019 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants