Fix description of an argument of sagemaker.session.train #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'input_config' should be an array which has channel objects.
laurenyu
reviewed
Feb 2, 2018
src/sagemaker/session.py
Outdated
| additional information about the training dataset. See :func:`sagemaker.session.s3_input` | ||
| for full details. | ||
|
|
||
| input_config (list): An array of Channel objects. Each channel is a named input source. |
There was a problem hiding this comment.
Could you add a link to the botocore docs?
There was a problem hiding this comment.
There are no links to botocore docs in this module. How about putting a link to Channel API document like session.py#L744?
There was a problem hiding this comment.
I meant the link you referenced in your PR description - since there's more information there about InputDataConfig, I think it'd be nice to make it clear where to find more information. A link to the Channel API doc would be a nice addition as well
There was a problem hiding this comment.
I see. I added the link to the description in 3671efe.
winstonaws
suggested changes
Feb 6, 2018
src/sagemaker/session.py
Outdated
| additional information about the training dataset. See :func:`sagemaker.session.s3_input` | ||
| for full details. | ||
|
|
||
| input_config (list): An array of Channel objects. Each channel is a named input source. Please refer to |
There was a problem hiding this comment.
Should be "A list of Channel objects". "Array" in python actually refers to a different type: https://docs.python.org/3/library/array.html
There was a problem hiding this comment.
@winstonaws Thanks. I fixed it in a7178c3.
winstonaws
approved these changes
Feb 7, 2018
jalabort
added a commit
to hudl/sagemaker-python-sdk
that referenced
this pull request
Mar 1, 2018
* Add data_type to hyperparameters (aws#54) When we describe a training job the data type of the hyper parameters is lost because we use a dict[str, str]. This adds a new field to Hyperparameter so that we can convert the datatypes at runtime. instead of validating with isinstance(), we cast the hp value to the type it is meant to be. This enforces a "strongly typed" value. When we deserialize from the API string responses it becomes easier to deal with too. * Add wrapper for LDA. (aws#56) Update CHANGELOG and bump the version number. * Add support for async fit() (aws#59) when calling fit(wait=False) it will return immediately. The training job will carry on even if the process exits. by using attach() the estimator can be retrieved by providing the training job name. _prepare_init_params_from_job_description() is now a classmethod instead of being a static method. Each class is responsible to implement their specific logic to convert a training job description into arguments that can be passed to its own __init__() * Fix Estimator role expansion (aws#68) Instead of manually constructing the role ARN, use the IAM boto client to do it. This properly expands service-roles and regular roles. * Add FM and LDA to the documentation. (aws#66) * Fix description of an argument of sagemaker.session.train (aws#69) * Fix description of an argument of sagemaker.session.train 'input_config' should be an array which has channel objects. * Add a link to the botocore docs * Use 'list' instead of 'array' in the description * Add ntm algorithm with doc, unit tests, integ tests (aws#73) * JSON serializer: predictor.predict accepts dictionaries (aws#62) Add support for serializing python dictionaries to json Add prediction with dictionary in tf iris integ test * Fixing timeouts for PCA async integration test. (aws#78) Execute tf_cifar test without logs to eliminate delay to detect that job has finished. * Fixes in LinearLearner and unit tests addition. (aws#77) * Print out billable seconds after training completes (aws#30) * Added: print out billable seconds after training completes * Fixed: test_session.py to pass unit tests * Fixed: removed offending tzlocal() * Use sagemaker_timestamp when creating endpoint names in integration tests. (aws#81) * Support TensorFlow-1.5.0 and MXNet-1.0.0 (aws#82) * Update .gitignore to ignore pytest_cache. * Support TensorFlow-1.5.0 and MXNet-1.0.0 * Update and refactor tests. Add tests for fw_utils. * Fix typo. * Update changelog for 1.1.0 (aws#85)
apacker
pushed a commit
to apacker/sagemaker-python-sdk
that referenced
this pull request
Nov 15, 2018
Removed: README from xgboost direct marketing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix description of an argument of
sagemaker.session.train.input_configshould be an array which has channel objects. The description ofinput_configis taken from https://botocore.readthedocs.io/en/latest/reference/services/sagemaker.html#SageMaker.Client.create_training_job.