Skip to content

Add region account map to marketplace test for canary #688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 10, 2019

Conversation

yangaws
Copy link
Contributor

@yangaws yangaws commented Mar 8, 2019

Issue #, if available:

Description of changes:

Marketplace algorithm and model package have different ARN in different regions. This PR handles this case.

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have updated the changelog with a description of my changes (if appropriate)
  • I have updated any necessary documentation (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@yangaws yangaws requested a review from iquintero March 8, 2019 08:25
@jesterhazy
Copy link
Contributor

AWS CodeBuild CI Report

  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@jesterhazy
Copy link
Contributor

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@yangaws yangaws merged commit 129bdb3 into aws:master Mar 10, 2019
mizanfiu pushed a commit to mizanfiu/sagemaker-python-sdk that referenced this pull request Dec 13, 2022
Co-authored-by: Zhenshan Jin <[email protected]>
Co-authored-by: Judy Heflin <[email protected]>
Co-authored-by: Zhenshan Jin <[email protected]>

@Zhenshan-Jin
feature: add create model card (aws#663) 

@Zhenshan-Jin
feature: add read update delete model card (aws#671) 

@Zhenshan-Jin
feature: model overview and training details autodiscovery (aws#674) 

@Zhenshan-Jin
feature: add metrics for training and evaluation details (aws#680) 

@Zhenshan-Jin
feature: model card export & list model card version history (aws#688) 

@Zhenshan-Jin
fix: batch update model card and bugs fixes (aws#712) 

@Zhenshan-Jin
@judyheflin
documentation: Amazon SageMaker Model Cards Python SDK documentation (aws#716)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants