Skip to content

Adding transformer method to PipelineModel #676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 11, 2019
Merged

Adding transformer method to PipelineModel #676

merged 7 commits into from
Mar 11, 2019

Conversation

andremoeller
Copy link
Contributor

Issue #, if available:

#661

Description of changes:

Adds transformer to PipelineModel, allowing you to run multi-container Batch Transform jobs from PipelineModel (without having already created a model).

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have updated the changelog with a description of my changes (if appropriate)
  • I have updated any necessary documentation (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

andremoeller
andremoeller commented Mar 1, 2019
View reviewed changes
@andremoeller andremoeller requested a review from jesterhazy March 1, 2019 16:06
orchidmajumder
orchidmajumder reviewed Mar 1, 2019
View reviewed changes
Copy link
Contributor

@orchidmajumder orchidmajumder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments, overall looks good.

Adding transformer method to PipelineModel
e7c9a02 
This enables creating multi-container Transform jobs
with PipelineModel without having already
created a SageMaker multi-container Model.
@jesterhazy
Copy link
Contributor

AWS CodeBuild CI Report

  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@andremoeller
Copy link
Contributor Author

I addressed @orchidmajumder s comments -- could an approved reviewer help move this PR forward?

Thanks!

@orchidmajumder
Copy link
Contributor

@andremoeller Github is telling me that there is no new changes since my last review. Have you updated your remote tracking branch to take care of the comments?

@andremoeller
Copy link
Contributor Author

@orchidmajumder Yes. I've force pushed (bad habit -- just trying to keep to one commit), so GitHub probably doesn't have the previous commits.

orchidmajumder
orchidmajumder previously approved these changes Mar 7, 2019
View reviewed changes
Copy link
Contributor

@orchidmajumder orchidmajumder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@andremoeller
Copy link
Contributor Author

Ping -- is there anything else to do before this can be merged in? Thanks.

laurenyu
laurenyu reviewed Mar 11, 2019
View reviewed changes
Copy link
Contributor

@laurenyu laurenyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a few small comments from me

@andremoeller
Copy link
Contributor Author

OK, fixed.

@jesterhazy
Copy link
Contributor

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@jesterhazy
Copy link
Contributor

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@laurenyu laurenyu merged commit 1787f78 into aws:master Mar 11, 2019
@andremoeller andremoeller deleted the PipelineModel branch March 12, 2019 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurenyu laurenyu laurenyu approved these changes

@orchidmajumder orchidmajumder orchidmajumder left review comments

@iquintero iquintero Awaiting requested review from iquintero

@jesterhazy jesterhazy Awaiting requested review from jesterhazy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@andremoeller @jesterhazy @orchidmajumder @iquintero @laurenyu