-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Make sure that an arn including 'role' won't pass #65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for contributing @matthieudelaro.
with the missing use? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add unit tests.
Codecov Report
@@ Coverage Diff @@
## master #65 +/- ##
=======================================
Coverage 92.79% 92.79%
=======================================
Files 71 71
Lines 5373 5373
=======================================
Hits 4986 4986
Misses 387 387
Continue to review full report at Codecov.
|
* Add initial Readme commit for PyTorch. * Update table of contents. Readme updates. * Add more info about distributed training. * PR comments. * Add notes about argparse actions and how to use boolean hyperparameters.
Add gluon sentiment analysis
continued this PR in #570 |
@laurenyu, thanks a lot for all you work that made the merging possible! |
Currently, an ARN such as the following
'arn:aws:iam::424242424242:user/matthieu_role'
is accepted as a valid ARN by the get_execution_role() function, despite the fact that a test has been implemented:Unfortunately, the test passes if ever the arn includes the term 'role'.
This commit improves this test by testing that 'role' is between a : and a /, in order to match arn like
arn:aws:iam::424242424242:role/sagemaker_role_matthieu