Skip to content

enable canary for EI supported regions #584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 7, 2019
Merged

enable canary for EI supported regions #584

merged 6 commits into from
Jan 7, 2019

Conversation

ChoiByungWook
Copy link
Contributor

@ChoiByungWook ChoiByungWook commented Jan 3, 2019

Description of changes:
Enabling the tests specified here as canaries: #527

The regions were determined based on: https://aws.amazon.com/machine-learning/elastic-inference/pricing/

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have updated the changelog with a description of my changes (if appropriate)
  • I have updated any necessary documentation (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-io
Copy link

codecov-io commented Jan 3, 2019

Codecov Report

Merging #584 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #584   +/-   ##
=======================================
  Coverage   92.78%   92.78%           
=======================================
  Files          71       71           
  Lines        5366     5366           
=======================================
  Hits         4979     4979           
  Misses        387      387

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7deab4b...a9dc076. Read the comment docs.

jesterhazy
jesterhazy previously approved these changes Jan 3, 2019
yangaws
yangaws previously approved these changes Jan 3, 2019
@ChoiByungWook ChoiByungWook dismissed stale reviews from yangaws and jesterhazy via 69322b8 January 4, 2019 04:38
@ChoiByungWook ChoiByungWook merged commit bc17302 into aws:master Jan 7, 2019
@ChoiByungWook ChoiByungWook deleted the ei_canary branch December 1, 2020 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants