Skip to content

Add sklearn and random cut forest to sdk docs #576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

eslesar-aws
Copy link
Contributor

Issue #, if available:

Description of changes:

I added an sklearn rst file in the doc directory, and added a corresponding section to the index.rst file to include it in the doc project. Also added randomcutforest to the list of 1st-party algorithms section in index.rst.

I have built the sphinx project locally and confirmed that the build looks correct.

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

  • [X ] I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have updated the changelog with a description of my changes (if appropriate)
  • I have updated any necessary documentation (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@yangaws yangaws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

There're still several 1p missing in the doc. But we can add it in new PRs.

@@ -80,6 +89,7 @@ Amazon provides implementations of some common machine learning algortithms opti
factorization_machines
lda
ntm
randomcutforest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this also needs a corresponding file. or just remove the added line because earlier today I did try to make files for all the missing 1P algos in #575

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@laurenyu I didn't see #575 ...this PR should be closed in favor of that one.

@laurenyu laurenyu mentioned this pull request Dec 21, 2018
4 tasks
@eslesar-aws eslesar-aws deleted the add-sklearn-docs branch December 27, 2018 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants