Skip to content

Remove __all__ from __init__.py files #571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 20, 2018
Merged

Conversation

laurenyu
Copy link
Contributor

@laurenyu laurenyu commented Dec 20, 2018

Issue #, if available: #553

Description of changes:
Removed all the instances I could find based on this search

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have updated the changelog with a description of my changes (if appropriate)
  • I have updated any necessary documentation (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@laurenyu laurenyu requested a review from nadiaya December 20, 2018 19:35
nadiaya
nadiaya previously approved these changes Dec 20, 2018
@codecov-io
Copy link

codecov-io commented Dec 20, 2018

Codecov Report

Merging #571 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #571      +/-   ##
==========================================
- Coverage   92.79%   92.78%   -0.01%     
==========================================
  Files          71       71              
  Lines        5373     5367       -6     
==========================================
- Hits         4986     4980       -6     
  Misses        387      387
Impacted Files Coverage Δ
src/sagemaker/sklearn/__init__.py 100% <100%> (ø) ⬆️
src/sagemaker/rl/__init__.py 100% <100%> (ø) ⬆️
src/sagemaker/pytorch/__init__.py 100% <100%> (ø) ⬆️
src/sagemaker/local/__init__.py 100% <100%> (ø) ⬆️
src/sagemaker/chainer/__init__.py 100% <100%> (ø) ⬆️
src/sagemaker/sparkml/__init__.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ef27a1...170dfe5. Read the comment docs.

@yangaws yangaws merged commit ed40f13 into aws:master Dec 20, 2018
@laurenyu laurenyu deleted the remove-init-all branch December 21, 2018 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants