move sagemaker_s3_output to model class #560
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#554
Description of changes:
Moved sagemaker_s3_output to model class.
There was a dependency error, in that a file in the local directory was taking dependency on a file in the rl directory.
I could have also allowed the rl directory to be properly scoped so that all directories have access, however that doesn't seem like the right call, as parameters and what not should be generic and not specific.
Reproduced customer error on a notebook instance and installed changes and tested properly.
It is difficult to write a test that catches this, as there seems to be weird interaction with tox and how our tests import classes. For now this is a quick fix.
Refactoring these parameters to a common class in the sagemaker directory might make things a little easier to manage.
Merge Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.