Skip to content

move sagemaker_s3_output to model class #560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 15, 2018
Merged

move sagemaker_s3_output to model class #560

merged 3 commits into from
Dec 15, 2018

Conversation

ChoiByungWook
Copy link
Contributor

@ChoiByungWook ChoiByungWook commented Dec 14, 2018

Issue #, if available:
#554

Description of changes:
Moved sagemaker_s3_output to model class.

There was a dependency error, in that a file in the local directory was taking dependency on a file in the rl directory.

I could have also allowed the rl directory to be properly scoped so that all directories have access, however that doesn't seem like the right call, as parameters and what not should be generic and not specific.

Reproduced customer error on a notebook instance and installed changes and tested properly.

It is difficult to write a test that catches this, as there seems to be weird interaction with tox and how our tests import classes. For now this is a quick fix.

Refactoring these parameters to a common class in the sagemaker directory might make things a little easier to manage.

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have updated the changelog with a description of my changes (if appropriate)
  • I have updated any necessary documentation (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ChoiByungWook ChoiByungWook merged commit 04f8abf into aws:master Dec 15, 2018
@ChoiByungWook ChoiByungWook deleted the local_output_error branch December 15, 2018 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants