Skip to content

Lowercase container hostnames #559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Dec 16, 2018
Merged

Lowercase container hostnames #559

merged 8 commits into from
Dec 16, 2018

Conversation

mvsusp
Copy link
Contributor

@mvsusp mvsusp commented Dec 14, 2018

Description of changes:

  • Docker hostnames are case sensitive. OpenSSH lowercases the hostnames before the
    handshake, given that UNIX hostnames should be case insensitive. This small change
    allows to run SSH inside local mode.

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have updated the changelog with a description of my changes (if appropriate)
  • I have updated any necessary documentation (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mvsusp mvsusp requested review from iquintero and laurenyu December 14, 2018 22:01
Copy link
Contributor

@laurenyu laurenyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changelog entry?

laurenyu
laurenyu previously approved these changes Dec 15, 2018
@codecov-io
Copy link

codecov-io commented Dec 15, 2018

Codecov Report

Merging #559 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #559   +/-   ##
=======================================
  Coverage   92.79%   92.79%           
=======================================
  Files          71       71           
  Lines        5372     5372           
=======================================
  Hits         4985     4985           
  Misses        387      387
Impacted Files Coverage Δ
src/sagemaker/local/image.py 88.53% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04f8abf...4bb59d6. Read the comment docs.

@ChoiByungWook ChoiByungWook self-requested a review December 15, 2018 02:09
Copy link
Contributor

@ChoiByungWook ChoiByungWook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mvsusp mvsusp merged commit 4b7db48 into aws:master Dec 16, 2018
@mvsusp mvsusp deleted the mvs-fix-hostname branch December 16, 2018 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants