-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Lowercase container hostnames #559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changelog entry?
Codecov Report
@@ Coverage Diff @@
## master #559 +/- ##
=======================================
Coverage 92.79% 92.79%
=======================================
Files 71 71
Lines 5372 5372
=======================================
Hits 4985 4985
Misses 387 387
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description of changes:
handshake, given that UNIX hostnames should be case insensitive. This small change
allows to run SSH inside local mode.
Merge Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.