Skip to content

fix flaky tfs test #536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

fix flaky tfs test #536

wants to merge 5 commits into from

Conversation

jesterhazy
Copy link
Contributor

Description of changes:

  • change test_tfs.py so fixture endpoint is not created in regions that should be skipped
  • will fix canary test errors in regions where this test is not supposed to be run

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have updated the changelog with a description of my changes (if appropriate)
  • I have updated any necessary documentation (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-io
Copy link

codecov-io commented Dec 8, 2018

Codecov Report

Merging #536 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #536   +/-   ##
=======================================
  Coverage   92.77%   92.77%           
=======================================
  Files          71       71           
  Lines        5357     5357           
=======================================
  Hits         4970     4970           
  Misses        387      387

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b3ab50...3e2f4c6. Read the comment docs.

@jesterhazy
Copy link
Contributor Author

closing. merged this fix into #537.

@jesterhazy jesterhazy closed this Dec 9, 2018
metrizable added a commit to metrizable/sagemaker-python-sdk that referenced this pull request Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants