increase docker-compose timeout to 120 and ping interval to 5 #525
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #525 +/- ##
==========================================
+ Coverage 92.71% 92.83% +0.11%
==========================================
Files 71 71
Lines 5343 5347 +4
==========================================
+ Hits 4954 4964 +10
+ Misses 389 383 -6
Continue to review full report at Codecov.
|
iquintero
previously approved these changes
Dec 5, 2018
iquintero
previously approved these changes
Dec 5, 2018
icywang86rui
reviewed
Dec 6, 2018
| @@ -2,6 +2,11 @@ | |||
| CHANGELOG | |||
| ========= | |||
|
|
|||
| 1.16.2dev | |||
| ====== | |||
There was a problem hiding this comment.
not critical - you need three more ===
jesterhazy
approved these changes
Dec 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Increase timeout of docker-compose to 120 along with ping for serving. Increase the interval between pings from 1 to 5.
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.