Skip to content

Add support for intermediate output to a local directory in local mode. #524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Dec 8, 2018

Conversation

nadiaya
Copy link
Contributor

@nadiaya nadiaya commented Dec 5, 2018

Add support for intermediate output to a local directory in local mode.

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have updated the changelog with a description of my changes (if appropriate)
  • I have updated any necessary documentation (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@nadiaya nadiaya requested a review from iquintero December 5, 2018 07:18
Copy link
Contributor

@iquintero iquintero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets discuss this offline, this I believe is not the proper way to do this.

@codecov-io
Copy link

codecov-io commented Dec 6, 2018

Codecov Report

Merging #524 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #524      +/-   ##
==========================================
+ Coverage    92.7%   92.71%   +<.01%     
==========================================
  Files          71       71              
  Lines        5336     5342       +6     
==========================================
+ Hits         4947     4953       +6     
  Misses        389      389
Impacted Files Coverage Δ
src/sagemaker/local/image.py 87.98% <100%> (+0.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4d1d5f...d8d1d1c. Read the comment docs.

iquintero
iquintero previously approved these changes Dec 6, 2018
Copy link
Contributor

@iquintero iquintero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed Offline. This is a different scenario in which the intermediate files should be available as training is happening not at the end.

@jesterhazy jesterhazy merged commit c098f6b into aws:master Dec 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants