Skip to content

Update PyYAML version restriction according to requirement in docker-… #523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 5, 2018

Conversation

yangaws
Copy link
Contributor

@yangaws yangaws commented Dec 5, 2018

…compose

Issue #, if available:

Description of changes:
https://github.com/docker/compose/blob/master/setup.py
docker-compose has this version restriction of PyYAML and we don't have the upper bound here. Our API docs https://sagemaker.readthedocs.io/en/latest/index.html then will install version 4.2b and failed to build.
So this PR made the version restriction of PyYAML consistent with docker-compose.

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have updated the changelog with a description of my changes (if appropriate)
  • I have updated any necessary documentation (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@yangaws yangaws requested a review from iquintero December 5, 2018 00:10
@codecov-io
Copy link

Codecov Report

Merging #523 into master will decrease coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #523      +/-   ##
=========================================
- Coverage   92.82%   92.7%   -0.12%     
=========================================
  Files          71      71              
  Lines        5336    5336              
=========================================
- Hits         4953    4947       -6     
- Misses        383     389       +6
Impacted Files Coverage Δ
src/sagemaker/local/image.py 87.76% <0%> (-1.84%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d60f8d3...795fdf7. Read the comment docs.

@yangaws yangaws merged commit b4d1d5f into aws:master Dec 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants