Skip to content

fix: parameter mismatch in update_endpoint #5135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dtaivpp
Copy link

@dtaivpp dtaivpp commented Apr 18, 2025

Issue #, if available:
Closes: #5130

Description of changes:
There is a parameter name mismatch that causes updating endpoints to fail as serverless_inference_config should be serverless_inference_config_dict.

Testing done:
I've made these changes locally and ensured the update_endpoint flag works:

/Users/dtaivpp/.pyenv/versions/issues_semantic/lib/python3.13/site-packages/pydantic/_internal/_fields.py:198: UserWarning: Field name "json" in "MonitoringDatasetFormat" shadows an attribute in parent "Base"
  warnings.warn(
[04/17/25 23:24:16] INFO     Found credentials in  credentials.py:1352
                             shared credentials                       
                             file:                                    
                             ~/.aws/credentials                       
sagemaker.config INFO - Not applying SDK defaults from location: /Library/Application Support/sagemaker/config.yaml
sagemaker.config INFO - Not applying SDK defaults from location: /Users/dtaivpp/Library/Application Support/sagemaker/config.yaml
[04/17/25 23:24:17] INFO     Found credentials in  credentials.py:1352
                             shared credentials                       
                             file:                                                          
[04/17/25 23:24:18] INFO     Repacking model artifact     model.py:820
                             (s3:/bucket/file.tar.gz),                
                             script artifact (.), and                 
                             dependencies ([]) into                   
                             single tar.gz file located               
                             at                                       
                             s3://model.tar.gz. This               
                             may take some time depending             
                             on model size...                         
[04/17/25 23:37:16] INFO     Creating model with name: session.py:4094
                             huggingface-pytorch-infer                
                             ence-2025-04-18-03-37-16-                
                             326                                      
[04/17/25 23:37:17] INFO     Creating endpoint-config  session.py:4610
                             with name                                
                             huggingface-pytorch-infer                
                             ence-2025-04-18-03-37-16-                
                             326                                      
-------!Model deployed successfully to endpoint: medembed-endpoint
Allow a few minutes for the endpoint to fully update if this was an update operation.

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)
  • If adding any dependency in requirements.txt files, I have spell checked and ensured they exist in PyPi

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@dtaivpp dtaivpp requested a review from a team as a code owner April 18, 2025 03:49
@dtaivpp dtaivpp requested a review from chad119 April 18, 2025 03:49
@dtaivpp
Copy link
Author

dtaivpp commented Apr 21, 2025

@mufaddal-rohawala anything else needed on this? I've been running this locally for the last few days now and it's worked consistently.

@dtaivpp
Copy link
Author

dtaivpp commented Apr 23, 2025

@chad119 Anything I can do to help with this? It's a blocker for using this feature right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parameter mismatch on the endpoint update of sagemaker model
2 participants