Added handler for pipeline variable while creating process job #5122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aining script which can misguide users.Training script can be of latest version based on the support provided by framework_version of the container
rsareddy0329
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
nargokul
reviewed
Apr 8, 2025
src/sagemaker/processing.py
Outdated
Comment on lines
512
to
513
| def _normalize_pipeline_variable(self, value): | ||
| """Helper function to normalize PipelineVariable objects""" |
There was a problem hiding this comment.
What does normalize mean in this case ?
Is this like a to_string ? We can probably rename this .
src/sagemaker/processing.py
Outdated
Comment on lines
515
to
526
| if isinstance(value, Parameter): | ||
| return str(value.default_value) if value.default_value is not None else None | ||
|
|
||
| elif isinstance(value, ExecutionVariable): | ||
| return f"{value.name}" | ||
|
|
||
| elif isinstance(value, Join): | ||
| normalized_values = [ | ||
| normalize_pipeline_variable(v) if isinstance(v, PipelineVariable) else str(v) | ||
| for v in value.values | ||
| ] | ||
| return value.on.join(normalized_values) |
There was a problem hiding this comment.
So this function is only called on value being PipelineVariable right ?
Why do we need the rest of the If conditions ?
src/sagemaker/processing.py
Outdated
Comment on lines
528
to
532
| elif isinstance(value, PipelineVariable): | ||
| if hasattr(value, 'default_value'): | ||
| return str(value.default_value) | ||
| elif hasattr(value, 'expr'): | ||
| return str(value.expr) |
There was a problem hiding this comment.
Can we instead overload the __str__ function within the class ?
src/sagemaker/processing.py
Outdated
| @@ -499,6 +509,37 @@ def _normalize_outputs(self, outputs=None): | |||
| normalized_outputs.append(output) | |||
| return normalized_outputs | |||
|
|
|||
| def _normalize_pipeline_variable(self, value): | |||
There was a problem hiding this comment.
Please add data types and return types
rsareddy0329
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
rsareddy0329
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
nargokul
approved these changes
Apr 10, 2025
gkatkov
approved these changes
Apr 10, 2025
rsareddy0329
pushed a commit
to rsareddy0329/sagemaker-python-sdk
that referenced
this pull request
Apr 14, 2025
10 tasks
rsareddy0329
added a commit
that referenced
this pull request
Apr 15, 2025
* change: Allow telemetry only in supported regions * change: Allow telemetry only in supported regions * change: Allow telemetry only in supported regions * change: Allow telemetry only in supported regions * change: Allow telemetry only in supported regions * documentation: Removed a line about python version requirements of training script which can misguide users.Training script can be of latest version based on the support provided by framework_version of the container * feature: Enabled update_endpoint through model_builder * fix: fix unit test, black-check, pylint errors * fix: fix black-check, pylint errors * fix:Added handler for pipeline variable while creating process job * fix: Added handler for pipeline variable while creating process job * Revert the PR changes: #5122, due to issue https://t.corp.amazon.com/P223568185/overview * Fix: fix the issue, https://t.corp.amazon.com/P223568185/communication --------- Co-authored-by: Roja Reddy Sareddy <[email protected]>
rsareddy0329
added a commit
that referenced
this pull request
Apr 20, 2025
* change: Allow telemetry only in supported regions * change: Allow telemetry only in supported regions * change: Allow telemetry only in supported regions * change: Allow telemetry only in supported regions * change: Allow telemetry only in supported regions * documentation: Removed a line about python version requirements of training script which can misguide users.Training script can be of latest version based on the support provided by framework_version of the container * feature: Enabled update_endpoint through model_builder * fix: fix unit test, black-check, pylint errors * fix: fix black-check, pylint errors * fix:Added handler for pipeline variable while creating process job * fix: Added handler for pipeline variable while creating process job * Revert the PR changes: #5122, due to issue https://t.corp.amazon.com/P223568185/overview * Fix: fix the issue, https://t.corp.amazon.com/P223568185/communication * Revert PR 5122 changes, due to issues with other processor codeflows --------- Co-authored-by: Roja Reddy Sareddy <[email protected]> Co-authored-by: Zhaoqi <[email protected]>
mollyheamazon
pushed a commit
that referenced
this pull request
Apr 21, 2025
* change: Allow telemetry only in supported regions * change: Allow telemetry only in supported regions * change: Allow telemetry only in supported regions * change: Allow telemetry only in supported regions * change: Allow telemetry only in supported regions * documentation: Removed a line about python version requirements of training script which can misguide users.Training script can be of latest version based on the support provided by framework_version of the container * feature: Enabled update_endpoint through model_builder * fix: fix unit test, black-check, pylint errors * fix: fix black-check, pylint errors * fix:Added handler for pipeline variable while creating process job * fix: Added handler for pipeline variable while creating process job --------- Co-authored-by: Roja Reddy Sareddy <[email protected]>
mollyheamazon
pushed a commit
that referenced
this pull request
Apr 21, 2025
* change: Allow telemetry only in supported regions * change: Allow telemetry only in supported regions * change: Allow telemetry only in supported regions * change: Allow telemetry only in supported regions * change: Allow telemetry only in supported regions * documentation: Removed a line about python version requirements of training script which can misguide users.Training script can be of latest version based on the support provided by framework_version of the container * feature: Enabled update_endpoint through model_builder * fix: fix unit test, black-check, pylint errors * fix: fix black-check, pylint errors * fix:Added handler for pipeline variable while creating process job * fix: Added handler for pipeline variable while creating process job * Revert the PR changes: #5122, due to issue https://t.corp.amazon.com/P223568185/overview * Fix: fix the issue, https://t.corp.amazon.com/P223568185/communication --------- Co-authored-by: Roja Reddy Sareddy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#3425
Description of changes:
PipelineVariableto handle json serialization error inargumentsbefore invokingcreate_process_jobTesting done:
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
unique_name_from_baseto create resource names in integ tests (if appropriate)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.