Skip to content

Remove unnecessary dependency tensorflow #511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 8, 2018
Merged

Conversation

yangaws
Copy link
Contributor

@yangaws yangaws commented Nov 27, 2018

Issue #, if available:

Description of changes:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have updated the changelog with a description of my changes (if appropriate)
  • I have updated any necessary documentation (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

mvsusp
mvsusp previously approved these changes Nov 28, 2018
mvsusp
mvsusp previously approved these changes Dec 1, 2018
nadiaya
nadiaya previously approved these changes Dec 5, 2018
@codecov-io
Copy link

Codecov Report

Merging #511 into master will increase coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #511      +/-   ##
==========================================
+ Coverage    92.7%   92.85%   +0.14%     
==========================================
  Files          71       71              
  Lines        5336     5331       -5     
==========================================
+ Hits         4947     4950       +3     
+ Misses        389      381       -8
Impacted Files Coverage Δ
src/sagemaker/tensorflow/__init__.py 100% <ø> (+18.18%) ⬆️
src/sagemaker/local/image.py 89.6% <0%> (+1.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4d1d5f...eb5ea46. Read the comment docs.

@jesterhazy jesterhazy dismissed stale reviews from nadiaya and mvsusp via 6b86a62 December 8, 2018 07:10
@jesterhazy jesterhazy merged commit 32ae9cf into aws:master Dec 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants