Skip to content

fix FileNotFoundError for entry_point without source_dir #510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 22, 2018

Conversation

jesterhazy
Copy link
Contributor

Description of changes:

  • fix FileNotFoundError for entry_point without source_dir

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have updated the changelog with a description of my changes (if appropriate)
  • I have updated any necessary documentation (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-io
Copy link

codecov-io commented Nov 22, 2018

Codecov Report

Merging #510 into master will decrease coverage by 0.12%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #510      +/-   ##
==========================================
- Coverage   94.26%   94.13%   -0.13%     
==========================================
  Files          59       59              
  Lines        4621     4623       +2     
==========================================
- Hits         4356     4352       -4     
- Misses        265      271       +6
Impacted Files Coverage Δ
src/sagemaker/fw_utils.py 100% <100%> (ø) ⬆️
src/sagemaker/local/image.py 87.76% <0%> (-1.84%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4f0f60...af35bbe. Read the comment docs.

ChoiByungWook
ChoiByungWook previously approved these changes Nov 22, 2018
Copy link
Contributor

@ChoiByungWook ChoiByungWook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome!

laurenyu
laurenyu previously approved these changes Nov 22, 2018
@jesterhazy jesterhazy dismissed stale reviews from laurenyu and ChoiByungWook via af35bbe November 22, 2018 01:28
nadiaya
nadiaya previously approved these changes Nov 22, 2018
laurenyu
laurenyu previously approved these changes Nov 22, 2018
@jesterhazy jesterhazy merged commit d8c055b into aws:master Nov 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants