Skip to content

Skip tests failed due to deprecated instance type #5097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 24, 2025
Merged

Skip tests failed due to deprecated instance type #5097

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions tests/integ/sagemaker/serve/test_serve_model_builder_gpu.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,8 @@ def model_builder(request):
def test_non_text_generation_model_single_GPU(
sagemaker_session, model_builder, model_input, **kwargs
):
if kwargs["instance_type"] == "ml.p2.xlarge":
pytest.skip("Instance type ml.p2.xlarge has been deprecated")
Comment on lines +99 to +100
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we not call this at all from the test ?

Why do we need this additional line for a deprecated instance

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the instance type could be ml.p3, which is not deprecated

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a list somewhere we can remove the usage of ml.p2?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No there isn't

iam_client = sagemaker_session.boto_session.client("iam")
role_arn = iam_client.get_role(RoleName="SageMakerRole")["Role"]["Arn"]
model = model_builder.build(role_arn=role_arn, sagemaker_session=sagemaker_session)
Expand Down Expand Up @@ -147,6 +149,8 @@ def test_non_text_generation_model_single_GPU(
def test_non_text_generation_model_multi_GPU(
sagemaker_session, model_builder, model_input, **kwargs
):
if kwargs["instance_type"] == "ml.p2.xlarge":
pytest.skip("Instance type ml.p2.xlarge has been deprecated")
iam_client = sagemaker_session.boto_session.client("iam")
role_arn = iam_client.get_role(RoleName="SageMakerRole")["Role"]["Arn"]
caught_ex = None
Expand Down
3 changes: 3 additions & 0 deletions tests/integ/sagemaker/serve/test_serve_transformers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,9 @@ def model_builder(request):
def test_pytorch_transformers_sagemaker_endpoint(
sagemaker_session, model_builder, model_input, **kwargs
):
if kwargs["instance_type"] == "ml.p2.xlarge":
pytest.skip("Instance type ml.p2.xlarge has been deprecated")

logger.info("Running in SAGEMAKER_ENDPOINT mode...")
caught_ex = None

Expand Down
Loading