Skip to content

fix: factor in set instance type when building JumpStart models in ModelBuilder. #5093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 20, 2025
Merged

fix: factor in set instance type when building JumpStart models in ModelBuilder. #5093

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c8d69c8
Remove main function entrypoint in ModelBuilder dependency manager.
Feb 25, 2025
793fa04
Merge branch 'aws:master' into master
cj-zhang Feb 25, 2025
b9e2517
Remove main function entrypoint in ModelBuilder dependency manager.
Feb 25, 2025
0254538
Merge branch 'aws:master' into master
cj-zhang Mar 18, 2025
0a72356
fix: factor in set instance type when building JumpStart models in Mo…
Mar 19, 2025
ca9e014
Remove default instance type from ModelBuilder.
Mar 19, 2025
579e359
Restore default instance type. Tweak integ test.
Mar 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/sagemaker/serve/builder/jumpstart_builder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,7 @@ def _create_pre_trained_js_model(self) -> Type[Model]:
vpc_config=self.vpc_config,
sagemaker_session=self.sagemaker_session,
name=self.name,
instance_type=self.instance_type,
)

self._original_deploy = pysdk_model.deploy
Expand Down
4 changes: 3 additions & 1 deletion tests/integ/sagemaker/serve/test_schema_builder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,9 @@

def test_model_builder_happy_path_with_only_model_id_text_generation(sagemaker_session):
model_builder = ModelBuilder(
model="HuggingFaceH4/zephyr-7b-beta", sagemaker_session=sagemaker_session
model="HuggingFaceH4/zephyr-7b-beta",
sagemaker_session=sagemaker_session,
instance_type=None,
)

model = model_builder.build(sagemaker_session=sagemaker_session)
Expand Down