Ensure Model.is_repack() returns a boolean #5060

pintaoz-aws · 2025-02-25T22:32:19Z

Issue #, if available:

Description of changes:
Ensure Model.is_repack() returns a boolean according to #4831

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)
If adding any dependency in requirements.txt files, I have spell checked and ensured they exist in PyPi

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

nargokul · 2025-02-26T16:56:32Z

tests/unit/sagemaker/model/test_framework_model.py

+    model = FrameworkModel(
+        role=ROLE,
+        sagemaker_session=sagemaker_session,
+        source_dir="s3://codebucket/someprefix/sourcedir.tar.gz",


Does this need to be changed to None ?

nargokul · 2025-02-26T16:58:53Z

src/sagemaker/model.py

+        if self.source_dir is None or self.entry_point is None:
+            return False
        return self.source_dir and self.entry_point and not self.git_config


I feel like this should already be covered in the existing line . Can we run the unit test without this change to verify ?

Can we update the line to be something like return self.source_dir is not None and self.entry_point is not None and self.git_config is None

in python None and None and True/False will return None. return self.source_dir is not None and self.entry_point is not None and self.git_config is None can not cover the case of empty string

* Ensure Model.is_repack() returns a boolean * update test --------- Co-authored-by: pintaoz <[email protected]>

author Molly He <[email protected]> 1740529460 -0800 committer Molly He <[email protected]> 1744156034 -0700 parent fb22b91 author Molly He <[email protected]> 1740529460 -0800 committer Molly He <[email protected]> 1744155953 -0700 parent fb22b91 author Molly He <[email protected]> 1740529460 -0800 committer Molly He <[email protected]> 1744155703 -0700 parent fb22b91 author Molly He <[email protected]> 1740529460 -0800 committer Molly He <[email protected]> 1744155683 -0700 Test py312 ci support Test py312 ci support first commit test to point to personal stack changed tox.ini Revert "changed tox.ini" This reverts commit 696cb47. Revert "Revert "changed tox.ini"" This reverts commit 5d35bd0. Revert "Revert "Revert "changed tox.ini""" This reverts commit 2ab95fb. Revert "Revert "changed tox.ini"" This reverts commit 5d35bd0. Revert "changed tox.ini" This reverts commit 696cb47. Revert "test to point to personal stack" This reverts commit 49de844. Revert "first commit" This reverts commit 1374184. add pyproject.toml add py312 to ci bump numpy version numpy version change add py312 upgrade pip version add setuptools wheel to tox.ini add pyyaml version constraint, remove py312 from docstring because there is no py312 image yet update pyyaml version constraint update pyyaml version constraint deprecate py38 bump scipy bump tensorflow and tensorboard bump dill bump apache-airflow to ensure dill and greenlet version remove constraint for apache-airflow remove constraint for apache-airflow bump torch version bump torchvision version new tests try changing some tests update model trainer test fix test_pipeline add constraint to apache in tox Fix key error in _send_metrics() (aws#5068) Co-authored-by: pintaoz <[email protected]> Use sagemaker session's s3_resource in download_folder (aws#5064) Co-authored-by: pintaoz <[email protected]> Fix error when there is no session to call _create_model_request() (aws#5062) * Fix error when there is no session to call _create_model_request() * Fix codestyle --------- Co-authored-by: pintaoz <[email protected]> Ensure Model.is_repack() returns a boolean (aws#5060) * Ensure Model.is_repack() returns a boolean * update test --------- Co-authored-by: pintaoz <[email protected]> feat: Make DistributedConfig Extensible (aws#5039) * feat: Make DistributedConfig Extensible * pylint * Include none types when creating config jsons for safer reference * fix: update test to account for changes * format * Add integ test * pylint * prepare release v2.240.0 * update development version to v2.240.1.dev0 * Fix key error in _send_metrics() (aws#5068) Co-authored-by: pintaoz <[email protected]> * fix: Added check for the presence of model package group before creating one (aws#5063) Co-authored-by: Keshav Chandak <[email protected]> * Use sagemaker session's s3_resource in download_folder (aws#5064) Co-authored-by: pintaoz <[email protected]> * remove union * fix merge artifact * Change dir path to distributed_drivers * update paths --------- Co-authored-by: ci <ci> Co-authored-by: pintaoz-aws <[email protected]> Co-authored-by: pintaoz <[email protected]> Co-authored-by: Keshav Chandak <[email protected]> Co-authored-by: Keshav Chandak <[email protected]> Skip tests with deprecated instance type (aws#5077) Co-authored-by: pintaoz <[email protected]> pipeline definition function doc update (aws#5074) Co-authored-by: Rohan Gujarathi <[email protected]> feat: add integ tests for training JumpStart models in private hub (aws#5076) * feat: add integ tests for training JumpStart models in private hub * fixed formatting * remove unused imports * fix unused imports * fix unit test failure and fix bug around versioning * fix formatting * fix unit tests * fix model_uri usage issue * fix some formatting * separate private hub setup code * add try catch block * fix flake8 issue so except clause is not bare * black formatting fix: resolve infinite loop in _find_config on Windows systems (aws#4970) * fix: resolve Windows path handling in _find_config * Replace Path.match("/") with Path.anchor comparison * Fix infinite loop in _studio.py path traversal * test: Add tests for the new root path exploration * Fix formatting style * Fixed line to long * Fix docstyle by running black manually * Fix testcase with \\ when running on non-windows machines * Fix formatting style * cleanup unused import change: update image_uri_configs 03-11-2025 07:18:09 PST Fixing Pytorch training python version in tests (aws#5084) * Fixing Pytorch training python version in tests * Updating Inference test handling remove s3 output location requirement from hub class init (aws#5081) * remove s3 output location requirement from hub class init * fix integ test hub * lint * fix test --------- Co-authored-by: Gokul Anantha Narayanan <[email protected]> fix: Prevent RunContext overlap between test_run tests (aws#5083) Co-authored-by: Gokul Anantha Narayanan <[email protected]> remove py38 from unit testing fix integ test by bumping py38 to py39 for PyTorch change framework_version that supports py39 in integ tests remove py38 from unit testing Update estimator.py

* Ensure Model.is_repack() returns a boolean * update test --------- Co-authored-by: pintaoz <[email protected]>

Ensure Model.is_repack() returns a boolean

c02edc9

pintaoz-aws requested a review from a team as a code owner February 25, 2025 22:32

pintaoz-aws requested a review from chad119 February 25, 2025 22:32

pintaoz-aws temporarily deployed to auto-approve February 25, 2025 22:32 — with GitHub Actions Inactive

nargokul reviewed Feb 26, 2025

View reviewed changes

update test

377cf15

pintaoz-aws temporarily deployed to auto-approve February 27, 2025 00:11 — with GitHub Actions Inactive

Merge branch 'master' into fix_model_is_repack

028a3a4

pintaoz-aws temporarily deployed to auto-approve February 28, 2025 18:21 — with GitHub Actions Inactive

chad119 approved these changes Mar 3, 2025

View reviewed changes

pintaoz-aws merged commit 921493d into aws:master Mar 5, 2025
13 of 14 checks passed

pintaoz-aws mentioned this pull request Mar 5, 2025

Model.is_repack should return a bool but sometimes returns a None #4831

Closed

mollyheamazon pushed a commit to mollyheamazon/sagemaker-python-sdk that referenced this pull request Mar 14, 2025

Ensure Model.is_repack() returns a boolean (aws#5060)

7c29b96

* Ensure Model.is_repack() returns a boolean * update test --------- Co-authored-by: pintaoz <[email protected]>

evakravi pushed a commit to evakravi/sagemaker-python-sdk that referenced this pull request Mar 20, 2025

Ensure Model.is_repack() returns a boolean (aws#5060)

805cb7a

* Ensure Model.is_repack() returns a boolean * update test --------- Co-authored-by: pintaoz <[email protected]>

mollyheamazon pushed a commit to mollyheamazon/sagemaker-python-sdk that referenced this pull request Apr 8, 2025

Ensure Model.is_repack() returns a boolean (aws#5060)

500fd92

* Ensure Model.is_repack() returns a boolean * update test --------- Co-authored-by: pintaoz <[email protected]>

mollyheamazon mentioned this pull request Apr 9, 2025

Py312 upgrade step 2: Update dependencies, integ tests and unit tests #5123

Merged

10 tasks

pravali96 pushed a commit to pravali96/sagemaker-python-sdk that referenced this pull request Apr 21, 2025

Ensure Model.is_repack() returns a boolean (aws#5060)

4a02f6c

* Ensure Model.is_repack() returns a boolean * update test --------- Co-authored-by: pintaoz <[email protected]>

mollyheamazon pushed a commit that referenced this pull request Apr 21, 2025

Ensure Model.is_repack() returns a boolean (#5060)

a8324ab

* Ensure Model.is_repack() returns a boolean * update test --------- Co-authored-by: pintaoz <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ensure Model.is_repack() returns a boolean #5060

Ensure Model.is_repack() returns a boolean #5060

pintaoz-aws commented Feb 25, 2025

nargokul Feb 26, 2025

pintaoz-aws Feb 27, 2025

nargokul Feb 26, 2025

pintaoz-aws Feb 27, 2025

Ensure Model.is_repack() returns a boolean #5060

Ensure Model.is_repack() returns a boolean #5060

Conversation

pintaoz-aws commented Feb 25, 2025

Merge Checklist

General

Tests

nargokul Feb 26, 2025

Choose a reason for hiding this comment

pintaoz-aws Feb 27, 2025

Choose a reason for hiding this comment

nargokul Feb 26, 2025

Choose a reason for hiding this comment

pintaoz-aws Feb 27, 2025

Choose a reason for hiding this comment