Skip to content

Remove main function entrypoint in ModelBuilder dependency manager. #5058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 25, 2025

Conversation

cj-zhang
Copy link
Collaborator

@cj-zhang cj-zhang commented Feb 25, 2025

Issue #, if available:

Description of changes:
Remove main() entrypoint in dependency_manager and invoke functions through python -c instead.

Testing done:
Local notebook testing and UTs succeed. Prepush checks succeed.

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)
  • If adding any dependency in requirements.txt files, I have spell checked and ensured they exist in PyPi

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@cj-zhang cj-zhang requested a review from a team as a code owner February 25, 2025 01:04
@cj-zhang cj-zhang requested a review from bhadrip February 25, 2025 01:04
@cj-zhang cj-zhang requested a review from mnuyens February 25, 2025 01:06
@rsareddy0329 rsareddy0329 self-requested a review February 25, 2025 04:58
@rsareddy0329 rsareddy0329 merged commit e68105c into aws:master Feb 25, 2025
14 checks passed
evakravi pushed a commit to evakravi/sagemaker-python-sdk that referenced this pull request Mar 20, 2025
…ws#5058)

* Remove main function entrypoint in ModelBuilder dependency manager.

* Remove main function entrypoint in ModelBuilder dependency manager.

---------

Co-authored-by: Joseph Zhang <[email protected]>
pravali96 pushed a commit to pravali96/sagemaker-python-sdk that referenced this pull request Apr 21, 2025
…ws#5058)

* Remove main function entrypoint in ModelBuilder dependency manager.

* Remove main function entrypoint in ModelBuilder dependency manager.

---------

Co-authored-by: Joseph Zhang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants