Skip to content

documentation: Removed a line about python version requirements of training script which can misguide users. #5057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Feb 25, 2025

Conversation

rsareddy0329
Copy link
Contributor

@rsareddy0329 rsareddy0329 commented Feb 24, 2025

Issue #, if available:
#2826

Description of changes:
Removed a line about python version requirements of training script which can misguide users. It is implicit that the Training script can be of latest version based on the framework_version and supported py_version of the container that will be provided here: https://github.com/aws/sagemaker-python-sdk/blob/master/src/sagemaker/pytorch/estimator.py#L144 while declaring the estimator.

Testing done:
yes, unit testing is done.

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate) - N/A
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes - N/A
  • I have checked that my tests are not configured for a specific region or account (if appropriate) - N/A
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate) - N/A
  • If adding any dependency in requirements.txt files, I have spell checked and ensured they exist in PyPi - N/A

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@rsareddy0329 rsareddy0329 marked this pull request as ready for review February 24, 2025 18:32
@rsareddy0329 rsareddy0329 requested a review from a team as a code owner February 24, 2025 18:32
@rsareddy0329 rsareddy0329 merged commit b116e2f into aws:master Feb 25, 2025
12 of 14 checks passed
evakravi pushed a commit to evakravi/sagemaker-python-sdk that referenced this pull request Mar 20, 2025
…aining script which can misguide users. (aws#5057)

* change: Allow telemetry only in supported regions

* change: Allow telemetry only in supported regions

* change: Allow telemetry only in supported regions

* change: Allow telemetry only in supported regions

* change: Allow telemetry only in supported regions

* documentation: Removed a line about python version requirements of training script which can misguide users.Training script can be of latest version based on the support provided by framework_version of the container

---------

Co-authored-by: Roja Reddy Sareddy <[email protected]>
pravali96 pushed a commit to pravali96/sagemaker-python-sdk that referenced this pull request Apr 21, 2025
…aining script which can misguide users. (aws#5057)

* change: Allow telemetry only in supported regions

* change: Allow telemetry only in supported regions

* change: Allow telemetry only in supported regions

* change: Allow telemetry only in supported regions

* change: Allow telemetry only in supported regions

* documentation: Removed a line about python version requirements of training script which can misguide users.Training script can be of latest version based on the support provided by framework_version of the container

---------

Co-authored-by: Roja Reddy Sareddy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants