Skip to content

fix: altconfig hubcontent and reenable integ test #5051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Feb 24, 2025
Merged

fix: altconfig hubcontent and reenable integ test #5051

merged 15 commits into from
Feb 24, 2025

Conversation

bencrabtree
Copy link
Collaborator

Issue #, if available:

Description of changes:
JumpStart team has an open Sev2 for failing Models with alt-configs.

TLDR:

  • Alt-config enabled models were added to the public Hub (HubService API) on 12/20 by this CR
  • PythonSDK was never updated to handle default alt-configs for HubContent (it handled S3 specs fine, also handled cases where customer specified an alt-config)
  • PythonSDK is the only channel that is affected by this. JavascriptSDK has support and BRMP is OOS as they do not contain alt-config models

Testing done:

  1. Recreate the error with one known failing model "meta-textgeneration-llama-2-13b-f"
  2. Ensure the known passing model is unaffected "meta-textgeneration-llama-3-2-1b"
  3. Make changes in the PR
  4. Successfully create a JumpStartModel and call .deploy on both models without errro

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)
  • If adding any dependency in requirements.txt files, I have spell checked and ensured they exist in PyPi

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@bencrabtree bencrabtree requested a review from a team as a code owner February 20, 2025 16:32
evakravi
evakravi reviewed Feb 20, 2025
View reviewed changes
evakravi
evakravi reviewed Feb 20, 2025
View reviewed changes
src/sagemaker/jumpstart/accessors.py
model_specs.set_hub_content_type(HubContentType.MODEL)

return model_specs
except Exception as ex:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we catch a more specific exception?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what do you suggest that is getting thrown from botocore?

evakravi
evakravi reviewed Feb 20, 2025
View reviewed changes
evakravi
evakravi reviewed Feb 20, 2025
View reviewed changes
@Aditi2424 Aditi2424 changed the title fix altconfig hubcontent and reenable integ test fix: altconfig hubcontent and reenable integ test Feb 24, 2025
@Aditi2424 Aditi2424 merged commit af7fb97 into aws:master Feb 24, 2025
13 of 14 checks passed
evakravi pushed a commit to evakravi/sagemaker-python-sdk that referenced this pull request Mar 20, 2025
@bencrabtree @malav-shastri @sagemaker-bot
fix: altconfig hubcontent and reenable integ test (aws#5051)
4a812f5 
* fix altconfig hubcontent and reenable integ test

* linting

* update exception thrown

* feat: Add support for TGI Neuronx 0.0.27 and HF PT 2.3.0 image in PySDK (aws#5050)

Co-authored-by: malavhs <[email protected]>

* add test

* update predictor spec accessor

* lint

* set custom field from HCD config to model spec data class

* lint

* remove logs

* last update

---------

Co-authored-by: Malav Shastri <[email protected]>
Co-authored-by: malavhs <[email protected]>
pravali96 pushed a commit to pravali96/sagemaker-python-sdk that referenced this pull request Apr 21, 2025
@bencrabtree @malav-shastri
fix: altconfig hubcontent and reenable integ test (aws#5051)
945db32 
* fix altconfig hubcontent and reenable integ test

* linting

* update exception thrown

* feat: Add support for TGI Neuronx 0.0.27 and HF PT 2.3.0 image in PySDK (aws#5050)

Co-authored-by: malavhs <[email protected]>

* add test

* update predictor spec accessor

* lint

* set custom field from HCD config to model spec data class

* lint

* remove logs

* last update

---------

Co-authored-by: Malav Shastri <[email protected]>
Co-authored-by: malavhs <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malav-shastri malav-shastri malav-shastri approved these changes

@evakravi evakravi evakravi approved these changes

@Aditi2424 Aditi2424 Aditi2424 approved these changes

@Narrohag Narrohag Narrohag approved these changes

@mohanasudhan mohanasudhan Awaiting requested review from mohanasudhan mohanasudhan is a code owner automatically assigned from aws/sagemaker-ml-frameworks

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bencrabtree @malav-shastri @evakravi @Aditi2424 @Narrohag