Move RecordSerializer and RecordDeserializer to sagemaker.serializers and sagemaker.deserialzers #5037
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and sagemaker.deserializers
pintaoz-aws
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
added 2 commits
February 13, 2025 14:41
pintaoz-aws
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
benieric
reviewed
Feb 14, 2025
| import logging | ||
| import struct | ||
| import sys | ||
|
|
||
| import numpy as np | ||
|
|
||
| from sagemaker.amazon.record_pb2 import Record | ||
| from sagemaker.deprecations import deprecated_class | ||
| from sagemaker.deserializers import SimpleBaseDeserializer |
There was a problem hiding this comment.
Would it make sense to re-import back here for backwards-compatibility ?
There was a problem hiding this comment.
This will lead to circular imports, unless we copy this entire file over and make it an empty file with only imports
chad119
approved these changes
Feb 17, 2025
This was referenced Feb 17, 2025
evakravi
pushed a commit
to evakravi/sagemaker-python-sdk
that referenced
this pull request
Mar 20, 2025
… and sagemaker.deserialzers (aws#5037) * Move RecordSerializer and RecordDeserializer to sagemaker.serializers and sagemaker.deserializers * fix codestyle * fix test --------- Co-authored-by: pintaoz <[email protected]>
pravali96
pushed a commit
to pravali96/sagemaker-python-sdk
that referenced
this pull request
Apr 21, 2025
… and sagemaker.deserialzers (aws#5037) * Move RecordSerializer and RecordDeserializer to sagemaker.serializers and sagemaker.deserializers * fix codestyle * fix test --------- Co-authored-by: pintaoz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#1994
Description of changes:
Move RecordSerializer and RecordDeserializer from sagemaker.amazon.common to sagemaker.serializers and sagemaker.deserialzers
Testing done:
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
unique_name_from_baseto create resource names in integ tests (if appropriate)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.