-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Change 'distribution' to 'distributions' in documentation #503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #503 +/- ##
==========================================
+ Coverage 92.7% 92.82% +0.11%
==========================================
Files 71 71
Lines 5336 5336
==========================================
+ Hits 4947 4953 +6
+ Misses 389 383 -6
Continue to review full report at Codecov.
|
you could add a new parameter 'distribution' and change the code to work with either. and add a deprecation warning on 'distributions' |
let's do a new PR later to add 'distribution' and change these docs back. |
Description of changes:
It was actually supposed to be "distribution" but even though the code is "wrong" and the docs are "right", we should stick with the "wrong" name for backward compatibility 😭
Merge Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.