Skip to content

Change 'distribution' to 'distributions' in documentation #503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 7, 2018

Conversation

laurenyu
Copy link
Contributor

@laurenyu laurenyu commented Nov 19, 2018

Description of changes:
It was actually supposed to be "distribution" but even though the code is "wrong" and the docs are "right", we should stick with the "wrong" name for backward compatibility 😭

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have updated the changelog with a description of my changes (if appropriate)
  • I have updated any necessary documentation (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-io
Copy link

codecov-io commented Nov 19, 2018

Codecov Report

Merging #503 into master will increase coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #503      +/-   ##
==========================================
+ Coverage    92.7%   92.82%   +0.11%     
==========================================
  Files          71       71              
  Lines        5336     5336              
==========================================
+ Hits         4947     4953       +6     
+ Misses        389      383       -6
Impacted Files Coverage Δ
src/sagemaker/mxnet/estimator.py 100% <ø> (ø) ⬆️
src/sagemaker/tensorflow/estimator.py 94.65% <ø> (ø) ⬆️
src/sagemaker/local/image.py 89.6% <0%> (+1.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15b1be7...ea536d6. Read the comment docs.

@jesterhazy
Copy link
Contributor

you could add a new parameter 'distribution' and change the code to work with either. and add a deprecation warning on 'distributions'

@jesterhazy
Copy link
Contributor

let's do a new PR later to add 'distribution' and change these docs back.

jesterhazy
jesterhazy previously approved these changes Dec 7, 2018
@jesterhazy jesterhazy merged commit cecea12 into aws:master Dec 7, 2018
@laurenyu laurenyu deleted the fix-docs branch December 10, 2018 17:29
ChoiByungWook pushed a commit that referenced this pull request Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants