Skip to content

Fix multiple IC support in modelBuilder #5015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/sagemaker/serve/builder/model_builder.py
Original file line number Diff line number Diff line change
Expand Up @@ -1621,7 +1621,6 @@ def deploy(
"""
if not hasattr(self, "built_model"):
raise ValueError("Model Needs to be built before deploying")
endpoint_name = unique_name_from_base(endpoint_name)
if not inference_config: # Real-time Deployment
return self.built_model.deploy(
instance_type=self.instance_type,
Expand Down Expand Up @@ -1655,6 +1654,7 @@ def deploy(
# Multi Model and MultiContainer endpoints with Inference Component
return self.built_model.deploy(
instance_type=self.instance_type,
endpoint_name=endpoint_name,
mode=Mode.SAGEMAKER_ENDPOINT,
endpoint_type=EndpointType.INFERENCE_COMPONENT_BASED,
resources=inference_config,
Expand Down
1 change: 1 addition & 0 deletions tests/unit/sagemaker/serve/builder/test_model_builder.py
Original file line number Diff line number Diff line change
Expand Up @@ -4080,6 +4080,7 @@ def test_neuron_configurations_rule_set(self):
"instance_type": "ml.g5.2xlarge",
"mode": Mode.SAGEMAKER_ENDPOINT,
"endpoint_type": EndpointType.INFERENCE_COMPONENT_BASED,
"endpoint_name": "test",
},
},
{
Expand Down
Loading