Skip to content

Bump version to 1.15.0 and remove local_mode_lock #496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 16, 2018
Merged

Conversation

laurenyu
Copy link
Contributor

The lock file is used locally for tests - doesn't need to be committed to the repo.

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have updated the changelog with a description of my changes (if appropriate)
  • I have updated any necessary documentation (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@laurenyu laurenyu requested a review from iquintero November 16, 2018 19:02
@codecov-io
Copy link

codecov-io commented Nov 16, 2018

Codecov Report

Merging #496 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #496   +/-   ##
=======================================
  Coverage   94.15%   94.15%           
=======================================
  Files          59       59           
  Lines        4498     4498           
=======================================
  Hits         4235     4235           
  Misses        263      263
Impacted Files Coverage Δ
src/sagemaker/__init__.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 537ba79...4ca0446. Read the comment docs.

iquintero
iquintero previously approved these changes Nov 16, 2018
@yangaws
Copy link
Contributor

yangaws commented Nov 16, 2018

https://github.com/aws/sagemaker-python-sdk/blob/master/doc/conf.py#L35

Do we need to change this api doc version?

@laurenyu laurenyu merged commit e37ac12 into aws:master Nov 16, 2018
@laurenyu laurenyu deleted the 1-15 branch November 16, 2018 21:42
metrizable pushed a commit to metrizable/sagemaker-python-sdk that referenced this pull request Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants