Skip to content

Fix: image_uris graviton image uri #4909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Fix: image_uris graviton image uri #4909

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 26 additions & 6 deletions tests/unit/sagemaker/image_uris/test_graviton.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,18 @@
]


def _test_graviton_framework_uris(framework, version, py_version, account, region):
def _test_graviton_framework_uris(
framework, version, py_version, account, region, container_version="ubuntu20.04-sagemaker"
):
for instance_type in GRAVITON_INSTANCE_TYPES:
uri = image_uris.retrieve(framework, region, instance_type=instance_type, version=version)
expected = _expected_graviton_framework_uri(
framework, version, py_version, account, region=region
framework,
version,
py_version,
account,
region=region,
container_version=container_version,
)
assert expected == uri

Expand All @@ -50,11 +57,21 @@ def test_graviton_framework_uris(load_config_and_file_name, scope):
for version in VERSIONS:
ACCOUNTS = config[scope]["versions"][version]["registries"]
py_versions = config[scope]["versions"][version]["py_versions"]
container_version = (
config[scope]["versions"][version].get("container_version", {}).get("cpu", None)
)
if container_version:
container_version = container_version + "-sagemaker"
for py_version in py_versions:
for region in ACCOUNTS.keys():
_test_graviton_framework_uris(
framework, version, py_version, ACCOUNTS[region], region
)
if container_version:
_test_graviton_framework_uris(
framework, version, py_version, ACCOUNTS[region], region, container_version
)
else:
_test_graviton_framework_uris(
framework, version, py_version, ACCOUNTS[region], region
)


def _test_graviton_unsupported_framework(framework, region, framework_version):
Expand Down Expand Up @@ -183,11 +200,14 @@ def test_graviton_sklearn_image_scope_specified_x86_instance(graviton_sklearn_un
assert "Unsupported instance type: m5." in str(error)


def _expected_graviton_framework_uri(framework, version, py_version, account, region):
def _expected_graviton_framework_uri(
framework, version, py_version, account, region, container_version
):
return expected_uris.graviton_framework_uri(
"{}-inference-graviton".format(framework),
fw_version=version,
py_version=py_version,
account=account,
region=region,
container_version=container_version,
)