Skip to content

feat: implemented security-monitoring to send metrics to CW #1510 #4821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 7, 2024

Conversation

mohamedzeidan2021
Copy link
Contributor

Issue #, if available:

Description of changes:
Created a workflow that calls the GitHub RESTAPI to list out the alerts in the repository, checks if any exist, and sends either a value of 1 or 0 depending on if any are found or not.

Testing done:
Tested in my fork and it successfully sends the metrics according to if there are security vuln or not.

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • [x ] I have read the CONTRIBUTING doc
  • [x ] I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • [ x] I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mohamedzeidan2021 mohamedzeidan2021 requested a review from a team as a code owner August 6, 2024 19:15
@mohamedzeidan2021 mohamedzeidan2021 requested a review from ptkab August 6, 2024 19:15
@mohamedzeidan2021 mohamedzeidan2021 removed the request for review from ptkab August 6, 2024 19:40
@sage-maker sage-maker merged commit 932c184 into aws:master Aug 7, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants