Skip to content

Merge master .github/workflows/codebuild-ci.yml #4611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

benieric
Copy link
Collaborator

Issue #, if available:

Description of changes:

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@benieric benieric requested a review from a team as a code owner April 24, 2024 01:07
@benieric benieric requested review from ptkab and removed request for a team April 24, 2024 01:07
Copy link

codecov bot commented Apr 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (master-jumpstart-curated-hub@9692b74). Click here to learn what that means.

Additional details and impacted files
@@                       Coverage Diff                       @@
##             master-jumpstart-curated-hub    #4611   +/-   ##
===============================================================
  Coverage                                ?   86.58%           
===============================================================
  Files                                   ?      400           
  Lines                                   ?    37915           
  Branches                                ?        0           
===============================================================
  Hits                                    ?    32829           
  Misses                                  ?     5086           
  Partials                                ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benieric benieric merged commit abb69e4 into aws:master-jumpstart-curated-hub Apr 24, 2024
@benieric benieric deleted the jumpstart-branch-ci-update branch April 24, 2024 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant