Skip to content

Flaky test #4580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 16, 2024
Merged

Flaky test #4580

merged 1 commit into from
Apr 16, 2024

Conversation

makungaj1
Copy link
Contributor

@makungaj1 makungaj1 commented Apr 15, 2024

Issue #, if available:

Description of changes:
ModelBuilder JS Gated model test failed because container failed to start, see below error.

torch.cuda.OutOfMemoryError: CUDA out of memory. 
Tried to allocate 172.00 MiB. GPU 0 has a total capacty of 
15.78 GiB of which 37.75 MiB is free. Process 11089 has 15.74 GiB memory in use. Of the allocated memory 14.06 GiB is allocated by PyTorch, and 470.23 MiB is reserved by PyTorch but unallocated.
 If reserved but unallocated memory is large try setting max_split_size_mb to avoid fragmentation.  See documentation for Memory Management and PYTORCH_CUDA_ALLOC_CONF

Revert to using stable JS non-gated model to unblock.

Testing done:
tox -e py39 -- tests/integ/sagemaker/serve/test_serve_js_happy.py

===================================================================================== 1 passed, 1 warning in 401.77s (0:06:41) =====================================================================================
.pkg: _exit> python /Users/makung/Documents/github/sagemaker-python-sdk/venv/lib/python3.9/site-packages/pyproject_api/_backend.py True setuptools.build_meta __legacy__
  py39: OK (418.62=setup[4.99]+cmd[0.04,3.06,1.71,1.65,2.89,404.28] seconds)
  congratulations :) (418.78 seconds)

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • [ x] I have read the CONTRIBUTING doc
  • [x ] I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • [ x] I used the commit message format described in CONTRIBUTING
  • [ x] I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • [ x] I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • [x ] I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • [x ] I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • [ x] I have checked that my tests are not configured for a specific region or account (if appropriate)
  • [ x] I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@makungaj1 makungaj1 requested a review from a team as a code owner April 15, 2024 22:16
@makungaj1 makungaj1 requested review from mohanasudhan and removed request for a team April 15, 2024 22:17
@samruds
Copy link
Collaborator

samruds commented Apr 15, 2024

  1. Can we add description of change here? I think we have moved from Gated to Non Gated model in endpoint mode.
  2. Can we add output or a single passed run of the failed test to description?

tox -e py310 -- -v -s tests/integ/sagemaker/serve/test_serve_js_happy.py::test_happy_tgi_sagemaker_endpoint

@samruds samruds requested review from samruds and knikure and removed request for mohanasudhan April 15, 2024 22:29
@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 1a4f0fe
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@knikure knikure merged commit 2f44975 into aws:master Apr 16, 2024
11 checks passed
malav-shastri pushed a commit to malav-shastri/sagemaker-python-sdk that referenced this pull request Jun 20, 2024
Co-authored-by: Jonathan Makunga <[email protected]>
jiapinw pushed a commit to jiapinw/sagemaker-python-sdk that referenced this pull request Jun 25, 2024
Co-authored-by: Jonathan Makunga <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants