Skip to content

[fix] disable modelbuilder mlflow local integ tests #4576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 12, 2024
Merged

[fix] disable modelbuilder mlflow local integ tests #4576

merged 1 commit into from
Apr 12, 2024

Conversation

jiapinw
Copy link
Contributor

@jiapinw jiapinw commented Apr 12, 2024

Issue #, if available:

Description of changes:

  • Disable modelbuilder mlflow local integ tests
  • Local container integ test is flaky since they all bind to the same hosts and cannot be run in parallel idempotently.

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

@samruds1 samruds1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mufaddal-rohawala mufaddal-rohawala marked this pull request as ready for review April 12, 2024 00:25
@mufaddal-rohawala mufaddal-rohawala requested a review from a team as a code owner April 12, 2024 00:25
@mufaddal-rohawala mufaddal-rohawala requested review from ptkab and removed request for a team April 12, 2024 00:25
@mufaddal-rohawala mufaddal-rohawala merged commit 9dcf8c2 into aws:master Apr 12, 2024
@jiapinw jiapinw deleted the fix-integ branch April 23, 2024 00:58
malav-shastri pushed a commit to malav-shastri/sagemaker-python-sdk that referenced this pull request Jun 20, 2024
jiapinw added a commit to jiapinw/sagemaker-python-sdk that referenced this pull request Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants