Skip to content

change: add integ-tests to codebuild-ci.yml #4575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

benieric
Copy link
Contributor

@benieric benieric commented Apr 11, 2024

Issue #, if available:

Description of changes:

  • migrate integ-tests to GitHub Actions trigger
  • add new integ-tests job to codebuild-ci.yml

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@benieric benieric requested a review from a team as a code owner April 11, 2024 19:52
@benieric benieric requested review from liujiaorr and removed request for a team April 11, 2024 19:52
@benieric benieric closed this Apr 11, 2024
@benieric benieric reopened this Apr 11, 2024
@benieric benieric temporarily deployed to manual-approval April 11, 2024 19:58 — with GitHub Actions Inactive
@benieric benieric force-pushed the master-add-integ-to-ci branch from da67aaf to 6c938df Compare April 11, 2024 20:03
@benieric benieric merged commit f21cce3 into aws:master Apr 11, 2024
@benieric benieric deleted the master-add-integ-to-ci branch June 19, 2024 06:38
malav-shastri pushed a commit to malav-shastri/sagemaker-python-sdk that referenced this pull request Jun 20, 2024
jiapinw pushed a commit to jiapinw/sagemaker-python-sdk that referenced this pull request Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants