Skip to content

Test SM PySDK Variations #4568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 11, 2024

Conversation

shantanutrip
Copy link
Collaborator

…in patch if inf patch already exists]

Issue #, if available:

Description of changes:

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@shantanutrip shantanutrip requested a review from a team as a code owner April 9, 2024 16:53
@shantanutrip shantanutrip requested review from akrishna1995 and removed request for a team April 9, 2024 16:53
@shantanutrip shantanutrip marked this pull request as draft April 9, 2024 16:53
@shantanutrip shantanutrip added the do-not-merge Use when PR needs to be marked as do not merge label Apr 9, 2024
@shantanutrip shantanutrip marked this pull request as ready for review April 9, 2024 20:33
@mufaddal-rohawala mufaddal-rohawala merged commit 067c34e into aws:master Apr 11, 2024
10 of 11 checks passed
shantanutrip added a commit to shantanutrip/sagemaker-python-sdk that referenced this pull request Apr 15, 2024
malav-shastri pushed a commit to malav-shastri/sagemaker-python-sdk that referenced this pull request Jun 20, 2024
* PT-inf-2.0.0 (PT-inf-2.0.1 JSON removed) PT-train-2.0.1[Increment train patch if inf patch already exists]

* Empty commit

* Empty commit 2
jiapinw pushed a commit to jiapinw/sagemaker-python-sdk that referenced this pull request Jun 25, 2024
* PT-inf-2.0.0 (PT-inf-2.0.1 JSON removed) PT-train-2.0.1[Increment train patch if inf patch already exists]

* Empty commit

* Empty commit 2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge Use when PR needs to be marked as do not merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants