-
Notifications
You must be signed in to change notification settings - Fork 1.2k
JumpStart Gated Model Support in ModelBuilder Local Modes #4567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samruds
suggested changes
Apr 9, 2024
samruds
approved these changes
Apr 9, 2024
gwang111
reviewed
Apr 9, 2024
gwang111
approved these changes
Apr 9, 2024
jiapinw
reviewed
Apr 9, 2024
jiapinw
approved these changes
Apr 9, 2024
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
mufaddal-rohawala
approved these changes
Apr 11, 2024
malav-shastri
pushed a commit
to malav-shastri/sagemaker-python-sdk
that referenced
this pull request
Jun 20, 2024
…4567) * Restrict JS Gated nodels only in SM Endpoint mode * Add tests * Address PR review comments * Resolve PR comments * Resolve PR comments * Resolve PR comments * Resolve PR comments * Fix integ tests * Fix tests * Fix tests * Fix integ tests --------- Co-authored-by: Jonathan Makunga <[email protected]>
jiapinw
pushed a commit
to jiapinw/sagemaker-python-sdk
that referenced
this pull request
Jun 25, 2024
…4567) * Restrict JS Gated nodels only in SM Endpoint mode * Add tests * Address PR review comments * Resolve PR comments * Resolve PR comments * Resolve PR comments * Resolve PR comments * Fix integ tests * Fix tests * Fix tests * Fix integ tests --------- Co-authored-by: Jonathan Makunga <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
JumpStart does not give customers direct access to gated model weights, this means that ModelBuilder's local modes cannot operate with a JumpStart gated models as weights need to be downloaded in customers' device.
This PR restricts JumpStart Gated Model to only ModelBuilder's endpoint mode. (Backward compatible)
Testing done:
Merge Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
unique_name_from_base
to create resource names in integ tests (if appropriate)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.