Skip to content

Remove notebook tests from CI health check and the script #4561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 4, 2024

Conversation

zhaoqizqwang
Copy link
Contributor

@zhaoqizqwang zhaoqizqwang commented Apr 4, 2024

Issue #, if available:

Description of changes:

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Update schema package to force the version to be 0.7.5 to avoid test failures
Removed notebook tests from CI health check;
Removed run-notebook-tests script
@zhaoqizqwang zhaoqizqwang requested a review from a team as a code owner April 4, 2024 20:24
@zhaoqizqwang zhaoqizqwang requested review from mohanasudhan and removed request for a team April 4, 2024 20:24
Copy link

codecov bot commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.44%. Comparing base (bda5f18) to head (c19f6e2).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4561      +/-   ##
==========================================
- Coverage   87.44%   87.44%   -0.01%     
==========================================
  Files         389      389              
  Lines       36889    36889              
==========================================
- Hits        32258    32257       -1     
- Misses       4631     4632       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: c19f6e2
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@zhaoqizqwang zhaoqizqwang merged commit abe1674 into aws:master Apr 4, 2024
malav-shastri pushed a commit to malav-shastri/sagemaker-python-sdk that referenced this pull request Jun 20, 2024
* Update schema dependency version

Update schema package to force the version to be 0.7.5 to avoid test failures

* Add new line to fix codestyle failure

* Remove notebook tests from CI and the script to run

Removed notebook tests from CI health check;
Removed run-notebook-tests script
jiapinw pushed a commit to jiapinw/sagemaker-python-sdk that referenced this pull request Jun 25, 2024
* Update schema dependency version

Update schema package to force the version to be 0.7.5 to avoid test failures

* Add new line to fix codestyle failure

* Remove notebook tests from CI and the script to run

Removed notebook tests from CI health check;
Removed run-notebook-tests script
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants