Skip to content

fix: typo in jumpstart manifest and refine tests #4558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 10, 2024

Conversation

Captainia
Copy link
Collaborator

Issue #, if available:

Description of changes:

Fixes a typo in JumpStart manifest enum, and refine the logic to retrieve manifest files.

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Captainia Captainia marked this pull request as ready for review April 4, 2024 15:13
@Captainia Captainia requested a review from a team as a code owner April 4, 2024 15:13
@Captainia Captainia requested review from knikure and removed request for a team April 4, 2024 15:13
Copy link

codecov bot commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.43%. Comparing base (d55290d) to head (84a711b).
Report is 1 commits behind head on master.

❗ Current head 84a711b differs from pull request most recent head b52c48e. Consider uploading reports for the commit b52c48e to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4558   +/-   ##
=======================================
  Coverage   87.43%   87.43%           
=======================================
  Files         389      389           
  Lines       36885    36885           
=======================================
  Hits        32252    32252           
  Misses       4633     4633           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 50d1925
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Member

@evakravi evakravi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wanna double check: you added a unit test that would've caught this error?

@Captainia
Copy link
Collaborator Author

wanna double check: you added a unit test that would've caught this error?

Yes added a test to prevent this - in local mode it is not supposed to fetch prop metadata.

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: c1a18bb
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 9a08f86
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 84a711b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 9c29a17
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@Captainia Captainia temporarily deployed to manual-approval April 10, 2024 15:12 — with GitHub Actions Inactive
@mufaddal-rohawala mufaddal-rohawala merged commit 208ef86 into aws:master Apr 10, 2024
11 checks passed
malav-shastri pushed a commit to malav-shastri/sagemaker-python-sdk that referenced this pull request Jun 20, 2024
* fix: type in manifest and refinement of tests

* add more tests

* add back a few tests

* black

* added one more test

* add test
jiapinw pushed a commit to jiapinw/sagemaker-python-sdk that referenced this pull request Jun 25, 2024
* fix: type in manifest and refinement of tests

* add more tests

* add back a few tests

* black

* added one more test

* add test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants