-
Notifications
You must be signed in to change notification settings - Fork 1.2k
fix: typo in jumpstart manifest and refine tests #4558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4558 +/- ##
=======================================
Coverage 87.43% 87.43%
=======================================
Files 389 389
Lines 36885 36885
=======================================
Hits 32252 32252
Misses 4633 4633 ☔ View full report in Codecov by Sentry. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wanna double check: you added a unit test that would've caught this error?
Yes added a test to prevent this - in local mode it is not supposed to fetch prop metadata. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
* fix: type in manifest and refinement of tests * add more tests * add back a few tests * black * added one more test * add test
* fix: type in manifest and refinement of tests * add more tests * add back a few tests * black * added one more test * add test
Issue #, if available:
Description of changes:
Fixes a typo in JumpStart manifest enum, and refine the logic to retrieve manifest files.
Testing done:
Merge Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
unique_name_from_base
to create resource names in integ tests (if appropriate)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.