add explicit pull for local serve #455
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 1, 2018 17:59
Codecov Report
@@ Coverage Diff @@
## master #455 +/- ##
==========================================
- Coverage 94.16% 94.13% -0.04%
==========================================
Files 59 59
Lines 4613 4621 +8
==========================================
+ Hits 4344 4350 +6
- Misses 269 271 +2
Continue to review full report at Codecov.
|
iquintero
reviewed
Nov 2, 2018
src/sagemaker/local/image.py
Outdated
|
|
||
| def _pull_image(image): | ||
| pull_image_command = ('docker pull %s' % image).strip() | ||
| print('docker command: {}'.format(pull_image_command)) |
There was a problem hiding this comment.
Shouldn't this be done through the logger?
There was a problem hiding this comment.
We set the log level to warning, so it ends up not showing up in jupyter :(.
There was a problem hiding this comment.
that's what log level are for. why force user to see this info-level message if they don't want to?
jesterhazy
suggested changes
Nov 11, 2018
apacker
pushed a commit
to apacker/sagemaker-python-sdk
that referenced
this pull request
Nov 15, 2018
jesterhazy
previously approved these changes
Nov 19, 2018
jesterhazy
approved these changes
Nov 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explicit pull for ECR image, as serve can potentially timeout due to ping.
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.