Skip to content

fix: add PT 2.2 support for smdistributed, pytorchddp, and torch_distributed distributions #4480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Mar 13, 2024
Merged

fix: add PT 2.2 support for smdistributed, pytorchddp, and torch_distributed distributions #4480

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
f548877
Add support for smdistributed, pytorchddp, torch_distributed for PT 2.2
ruhanprasad Mar 6, 2024
ffde5d1
Merge branch 'aws:master' into master
ruhanprasad Mar 6, 2024
7447877
formatting
ruhanprasad Mar 6, 2024
86a1a44
Merge branch 'master' into master
ruhanprasad Mar 6, 2024
4f51db9
Merge branch 'master' into master
ruhanprasad Mar 7, 2024
e450813
formatting
ruhanprasad Mar 8, 2024
1f60714
Merge branch 'master' into master
ruhanprasad Mar 11, 2024
6fb2916
Merge branch 'master' into master
ruhanprasad Mar 12, 2024
3018d99
Merge branch 'master' into master
ruhanprasad Mar 12, 2024
55b4ed3
Merge branch 'master' into master
liujiaorr Mar 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions src/sagemaker/estimator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3282,10 +3282,7 @@ class Framework(EstimatorBase):
"""

_framework_name = None
UNSUPPORTED_DLC_IMAGE_FOR_SM_PARALLELISM = (
"2.0.1-gpu-py310-cu121",
"2.0-gpu-py310-cu121",
)
UNSUPPORTED_DLC_IMAGE_FOR_SM_PARALLELISM = ("2.0.1-gpu-py310-cu121",)

def __init__(
self,
Expand Down
1 change: 0 additions & 1 deletion src/sagemaker/fw_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,6 @@
"2.2.0",
]


TORCH_DISTRIBUTED_GPU_SUPPORTED_FRAMEWORK_VERSIONS = [
"1.13.1",
"2.0.0",
Expand Down
2 changes: 2 additions & 0 deletions tests/unit/test_fw_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -933,6 +933,7 @@ def test_validate_smdataparallel_args_not_raises():
("ml.p3.16xlarge", "pytorch", "2.0.0", "py310", smdataparallel_enabled),
("ml.p3.16xlarge", "pytorch", "2.0.1", "py310", smdataparallel_enabled),
("ml.p3.16xlarge", "pytorch", "2.1.0", "py310", smdataparallel_enabled),
("ml.p3.16xlarge", "pytorch", "2.2.0", "py310", smdataparallel_enabled),
("ml.p3.16xlarge", "tensorflow", "2.4.1", "py3", smdataparallel_enabled_custom_mpi),
("ml.p3.16xlarge", "tensorflow", "2.4.1", "py37", smdataparallel_enabled_custom_mpi),
("ml.p3.16xlarge", "tensorflow", "2.4.3", "py3", smdataparallel_enabled_custom_mpi),
Expand All @@ -957,6 +958,7 @@ def test_validate_smdataparallel_args_not_raises():
("ml.p3.16xlarge", "pytorch", "2.0.0", "py310", smdataparallel_enabled_custom_mpi),
("ml.p3.16xlarge", "pytorch", "2.0.1", "py310", smdataparallel_enabled_custom_mpi),
("ml.p3.16xlarge", "pytorch", "2.1.0", "py310", smdataparallel_enabled_custom_mpi),
("ml.p3.16xlarge", "pytorch", "2.2.0", "py310", smdataparallel_enabled_custom_mpi),
]
for instance_type, framework_name, framework_version, py_version, distribution in good_args:
fw_utils._validate_smdataparallel_args(
Expand Down