Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feature: JumpStart CuratedHub class creation and function definitions #4448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: JumpStart CuratedHub class creation and function definitions #4448
Changes from 2 commits
4922511
f4da2ad
d5937b3
0435ae9
a4c67e8
4799ccb
086bf92
b600dd1
1506147
a8d6664
edb887e
5f24036
b0ce624
0937c74
7c87c52
dddd0a6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll actually parse
hub_model_description.hub_content_document
inside ofJumpStartModelSpecs
. You can see I stubbed out the code forfrom_content_document
in that data classThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll have conflicts in my PR #4439, but we should default to
DEFAULT_JUMPSTART_SAGEMAKER_SESSION
hereThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually thought about that and decided to derive session from the region if left None.
DEFAULT_JUMPSTART_SAGEMAKER_SESSION
is basically Session withJUMPSTART_DEFAULT_REGION_NAME
which isus-west-2
. It is a bit weird to get both region and the session, even with the regions check in line 37. I guess we can derive the region from the sagemaker_session actually.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry just seeing this reply- yes you're totally right. We don't need the
region
param since we can derive that fromsession
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For both fns in this file, I think we should 1/ accept a custom SM Session and 2/ default to the
DEFAULT_JUMPSTART_SAGEMAKER_SESSION
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reason behind not using the
DEFAULT_JUMPSTART_SAGEMAKER_SESSION
was becauseHub
is technically not just for JS.