Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feat/jsch jumpstart estimator support #4439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/jsch jumpstart estimator support #4439
Changes from 1 commit
032cb80
ef042d9
49ae11b
6175087
4c9b2d0
63345ea
6efc206
2e9f76f
ac8dd60
d4f7a00
5492474
1e26760
4ae201c
4a19a33
4d35379
174c4fd
b7a8835
bb7a9fb
8ba576a
ecd1f97
8df4478
4870c0b
4dc21f5
dd51314
195b84b
a39ae5f
354b33e
424254e
8a3160a
151350c
dd087da
a61dfb4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: capitalize
Default
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I missed this from the previous PR. But I am a bit confused about having HUB type here. Other three types are related to models (i.e. model id or sort maps to model specs).
formatted_content
as it currently only hasUnion[ Dict[JumpStartVersionedModelId, JumpStartModelHeader], JumpStartModelSpecs
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The previous implementation had two pathways:
JumpStartS3FileType.MANIFEST
(which fetched and cached the manifest) andJumpStartS3FileType.SPECS
(which fetched and cached model version specific spesc). We'll follow the same process here, where we cache the hub details (dependent on hub arn) and hub content details (dependent on hub content arn)To answer your other questions:
HubContentType.HUB
will store Hub information for a givenhubArn
.HubContentType.MODEL
will store HubContent information for a givenhubContentArn
. You're correct, we will have to implement other functions to retrieve the Hub information correctly, but this PR does not contain that logic