Skip to content

feat: Introduce HF Transformers to ModelBuilder #4368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Feb 2, 2024
Merged

feat: Introduce HF Transformers to ModelBuilder #4368

merged 14 commits into from
Feb 2, 2024

Conversation

samruds
Copy link
Collaborator

@samruds samruds commented Jan 10, 2024 •
edited
Loading

Issue #, if available: #4284

Description of changes:

Introduce the HF Model Builder
Add unit tests

Testing done:
Tested changes using Local and Sagemaker endpoint mode

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@samruds samruds requested a review from a team as a code owner January 10, 2024 22:08
@samruds samruds requested review from EvelynYan21 and removed request for a team January 10, 2024 22:08
@gwang111
Copy link
Collaborator

please rename to feat: Introduce HF DLC to ModelBuilder

@gwang111
Copy link
Collaborator

i think we should also add additional unit testing. I don't see coverage for the new hf_dlc_builder.py

@samruds samruds closed this Jan 12, 2024
@samruds samruds changed the title Introduce HF DLC to Model Builder feat: Introduce HF DLC to ModelBuilder Jan 12, 2024
@samruds samruds reopened this Jan 12, 2024
@samruds
Copy link
Collaborator Author

samruds commented Jan 16, 2024

i think we should also add additional unit testing. I don't see coverage for the new hf_dlc_builder.py

Added UT

jiapinw
jiapinw suggested changes Jan 16, 2024
View reviewed changes
@samruds samruds force-pushed the master branch 6 times, most recently from 7ee395a to 6b307c0 Compare January 17, 2024 20:39
@mufaddal-rohawala
Copy link
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: f8e820d
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@samruds samruds force-pushed the master branch 2 times, most recently from acc4ec0 to faa93e5 Compare February 2, 2024 02:19
@mufaddal-rohawala
Copy link
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: faa93e5
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@samruds samruds force-pushed the master branch 8 times, most recently from 6f1e976 to 5bd854e Compare February 2, 2024 04:15
@mufaddal-rohawala
Copy link
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 5bd854e
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mufaddal-rohawala
Copy link
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 5bd854e
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mufaddal-rohawala
Copy link
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 3d6636b
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@samruds samruds force-pushed the master branch 2 times, most recently from 924983d to b52db03 Compare February 2, 2024 04:42
@mufaddal-rohawala
Copy link
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: ba850c2
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mufaddal-rohawala
Copy link
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: ba850c2
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mufaddal-rohawala
Copy link
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: ba850c2
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mufaddal-rohawala
Copy link
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: ba850c2
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mufaddal-rohawala
Copy link
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: ba850c2
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@benieric benieric merged commit 8eea80a into aws:master Feb 2, 2024
Captainia pushed a commit to Captainia/sagemaker-python-sdk that referenced this pull request Feb 29, 2024
@samruds
feat: Introduce HF Transformers to ModelBuilder (aws#4368)
e477d1e 
* feat: Introduce HF Transformers to ModelBuilder

* Add integ test

* Revert the change in comment for tgi prepare

* Capitalize enum

* Address PR feedbacks

* Format files

* Format files

* Address PR feedbacks

* Address PR feedbacks

* Fix test builds
jiapinw pushed a commit to jiapinw/sagemaker-python-sdk that referenced this pull request Jun 25, 2024
@samruds @jiapinw
feat: Introduce HF Transformers to ModelBuilder (aws#4368)
8726294 
* feat: Introduce HF Transformers to ModelBuilder

* Add integ test

* Revert the change in comment for tgi prepare

* Capitalize enum

* Address PR feedbacks

* Format files

* Format files

* Address PR feedbacks

* Address PR feedbacks

* Fix test builds
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gwang111 gwang111 gwang111 approved these changes

@jiapinw jiapinw jiapinw requested changes

@qiyunz qiyunz qiyunz approved these changes

@mohanasudhan mohanasudhan mohanasudhan approved these changes

@makungaj1 makungaj1 makungaj1 approved these changes

@benieric benieric benieric approved these changes

@EvelynYan21 EvelynYan21 Awaiting requested review from EvelynYan21 EvelynYan21 is a code owner automatically assigned from aws/sagemaker-ml-frameworks

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[HuggingFace] use default Hugging Face Inference DLC for non TGI models when using ModelBuilder
9 participants
@samruds @gwang111 @mufaddal-rohawala @codecov-commenter @qiyunz @mohanasudhan @makungaj1 @jiapinw @benieric