Skip to content

fix: relax upper bound for urllib dependency #4364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 1, 2024
Merged

fix: relax upper bound for urllib dependency #4364

merged 1 commit into from
Feb 1, 2024

Conversation

jmahlik
Copy link
Contributor

@jmahlik jmahlik commented Jan 8, 2024

Closes #4362

Issue #, if available: #4362

Description of changes:
Relax the urllib deps to allow using newer versions. Boto supports them as well.

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jmahlik jmahlik requested a review from a team as a code owner January 8, 2024 19:34
@jmahlik jmahlik requested review from mohanasudhan and removed request for a team January 8, 2024 19:34
@jmahlik jmahlik requested a review from mohanasudhan January 19, 2024 00:23
@jmahlik
Copy link
Contributor Author

jmahlik commented Jan 19, 2024

@mohanasudhan am I able to /bot run all once it is approved? Or is that locked to maintainers?

@mohanasudhan
Copy link
Contributor

Its locked to maintainers. We are taking deeper in the code-build failures and planning to revamp. Apologies for inconvenience.

@mohanasudhan
Copy link
Contributor

/bot run all

@jmahlik
Copy link
Contributor Author

jmahlik commented Jan 19, 2024

Totally understand why it is locked down. Doesn't seem like the bot worked there. Just let me know if a rebase is needed again happy to do it.

@jmahlik jmahlik requested a review from mohanasudhan January 22, 2024 14:22
knikure
knikure reviewed Jan 24, 2024
View reviewed changes
Copy link
Contributor

@knikure knikure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/bot run all

@mufaddal-rohawala
Copy link
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 8da8b49
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mufaddal-rohawala
Copy link
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 8da8b49
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mufaddal-rohawala
Copy link
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 8da8b49
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@codecov-commenter
Copy link

codecov-commenter commented Jan 24, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8b206ba) 86.94% compared to head (259ed3e) 86.84%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4364      +/-   ##
==========================================
- Coverage   86.94%   86.84%   -0.10%     
==========================================
  Files        1203      382     -821     
  Lines      107211    35315   -71896     
==========================================
- Hits        93211    30671   -62540     
+ Misses      14000     4644    -9356

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mufaddal-rohawala
Copy link
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 8da8b49
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mufaddal-rohawala
Copy link
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 8da8b49
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@jmahlik
Copy link
Contributor Author

jmahlik commented Jan 24, 2024

It looks like these are unrelated flakey tests. Thoughts on merging this or should I try to rebase?

@jmahlik jmahlik requested a review from knikure January 31, 2024 16:46
@jmahlik
Copy link
Contributor Author

jmahlik commented Jan 31, 2024

If it is easier for y'all to make the change, I can close this MR. The urllib restriction is causing some pretty big issues downstream.

benieric
benieric reviewed Jan 31, 2024
View reviewed changes
Copy link
Contributor

@benieric benieric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/bot run all

@mufaddal-rohawala
Copy link
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 259ed3e
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mufaddal-rohawala
Copy link
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 259ed3e
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mufaddal-rohawala
Copy link
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 259ed3e
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mufaddal-rohawala
Copy link
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 259ed3e
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mufaddal-rohawala
Copy link
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 259ed3e
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

benieric
benieric reviewed Jan 31, 2024
View reviewed changes
Copy link
Contributor

@benieric benieric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/bot run local-mode-tests

@mufaddal-rohawala
Copy link
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 259ed3e
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@knikure knikure merged commit f8d90ce into aws:master Feb 1, 2024
Captainia pushed a commit to Captainia/sagemaker-python-sdk that referenced this pull request Feb 29, 2024
@jmahlik
fix: relax upper bound for urllib dependency (aws#4364)
7d4e65c 
Closes aws#4362
jiapinw pushed a commit to jiapinw/sagemaker-python-sdk that referenced this pull request Jun 25, 2024
@jmahlik @jiapinw
fix: relax upper bound for urllib dependency (aws#4364)
e4135d7 
Closes aws#4362
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benieric benieric benieric left review comments

@knikure knikure knikure approved these changes

@mohanasudhan mohanasudhan Awaiting requested review from mohanasudhan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove upper bound on urllib in the requirements
6 participants
@jmahlik @mohanasudhan @mufaddal-rohawala @codecov-commenter @knikure @benieric