Skip to content

remove request size limit in doc comments #433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 19, 2018
Merged

Conversation

jesterhazy
Copy link
Contributor

Description of changes:

remove request size limit in doc comments

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have updated the changelog with a description of my changes (if appropriate)
  • I have updated any necessary documentation (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jesterhazy jesterhazy requested a review from mvsusp October 17, 2018 15:47
mvsusp
mvsusp previously approved these changes Oct 17, 2018
nadiaya
nadiaya previously approved these changes Oct 19, 2018
@jesterhazy jesterhazy dismissed stale reviews from nadiaya and mvsusp via 78899bf October 19, 2018 17:20
@codecov-io
Copy link

codecov-io commented Oct 19, 2018

Codecov Report

Merging #433 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #433      +/-   ##
==========================================
+ Coverage   93.75%   93.75%   +<.01%     
==========================================
  Files          55       55              
  Lines        4032     4033       +1     
==========================================
+ Hits         3780     3781       +1     
  Misses        252      252
Impacted Files Coverage Δ
src/sagemaker/__init__.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08bacf6...14da198. Read the comment docs.

@jesterhazy jesterhazy force-pushed the master branch 2 times, most recently from 14da198 to 33455c4 Compare October 19, 2018 17:33
@nadiaya nadiaya merged commit c4053ff into aws:master Oct 19, 2018
pdasamzn pushed a commit to pdasamzn/sagemaker-python-sdk that referenced this pull request Nov 1, 2018
apacker pushed a commit to apacker/sagemaker-python-sdk that referenced this pull request Nov 15, 2018
Fix dockerfile to work in other regions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants