Skip to content

Change: Mention "FastFile" support for s3_input_mode in docstrings #4311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 7, 2023
Merged

Change: Mention "FastFile" support for s3_input_mode in docstrings #4311

merged 1 commit into from
Dec 7, 2023

Conversation

martinRenou
Copy link
Collaborator

Issue #, if available:

Raised in #3962

Description of changes:

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@martinRenou martinRenou marked this pull request as ready for review December 7, 2023 10:44
@martinRenou martinRenou requested a review from a team as a code owner December 7, 2023 10:44
@martinRenou martinRenou requested review from EvelynYan21 and removed request for a team December 7, 2023 10:44
@mufaddal-rohawala
Copy link
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 7bb09c6
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mufaddal-rohawala
Copy link
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 0d6b3bf
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mufaddal-rohawala
Copy link
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 0d6b3bf
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mufaddal-rohawala
Copy link
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 0d6b3bf
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mufaddal-rohawala
Copy link
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 0d6b3bf
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mufaddal-rohawala
Copy link
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 0d6b3bf
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@codecov-commenter
Copy link

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (72e5028) 86.70% compared to head (0d6b3bf) 86.54%.
Report is 5 commits behind head on master.

Files Patch % Lines
...c/sagemaker/serve/marshalling/triton_translator.py 40.00% 6 Missing ⚠️
src/sagemaker/workflow/pipeline.py 92.59% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4311      +/-   ##
==========================================
- Coverage   86.70%   86.54%   -0.17%     
==========================================
  Files        1197      380     -817     
  Lines      105630    34881   -70749     
==========================================
- Hits        91586    30187   -61399     
+ Misses      14044     4694    -9350

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martinRenou
Copy link
Collaborator Author

@mohanasudhan I feel the CI for this PR is not failing for a reason specific to the PR. The PR only changes docstring and passes the linting test.

@mohanasudhan
Copy link
Contributor

ack

@akrishna1995 akrishna1995 self-requested a review December 7, 2023 18:50
akrishna1995
akrishna1995 approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@akrishna1995 akrishna1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doc changes - RLE causing issues, safe to merge this

@akrishna1995 akrishna1995 merged commit 0b13d2a into aws:master Dec 7, 2023
@mufaddal-rohawala
Copy link
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 8b37a14
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mufaddal-rohawala
Copy link
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 8b37a14
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mufaddal-rohawala
Copy link
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 8b37a14
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mufaddal-rohawala
Copy link
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 8b37a14
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mufaddal-rohawala
Copy link
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 8b37a14
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@martinRenou martinRenou deleted the fast_file_docs branch December 8, 2023 09:29
@jbschiratti jbschiratti mentioned this pull request Apr 17, 2024
Closed
knikure pushed a commit to knikure/sagemaker-python-sdk that referenced this pull request May 8, 2024
@martinRenou @sagemaker-bot
Change: Mention "FastFile" support for s3_input_mode in docstrings (a…
f9627e0 
…ws#4311)
@joonb14 joonb14 mentioned this pull request May 31, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohanasudhan mohanasudhan mohanasudhan approved these changes

@akrishna1995 akrishna1995 akrishna1995 approved these changes

@EvelynYan21 EvelynYan21 Awaiting requested review from EvelynYan21 EvelynYan21 is a code owner automatically assigned from aws/sagemaker-ml-frameworks

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@martinRenou @mufaddal-rohawala @codecov-commenter @mohanasudhan @akrishna1995