Skip to content

Improve local mode transformer test #430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 13, 2018
Merged

Improve local mode transformer test #430

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e0453d5
Improve local mode transformer test
Oct 13, 2018
12bc4cc
Merge branch 'master' into minor_fixes
iquintero Oct 13, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion tests/integ/test_local_mode.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -368,8 +368,9 @@ def test_mxnet_local_data_local_script():
fcntl.lockf(local_mode_lock, fcntl.LOCK_UN)


@pytest.mark.continuous_testing
def test_local_transform_mxnet(sagemaker_local_session, tmpdir):
local_mode_lock_fd = open(LOCK_PATH, 'w')
local_mode_lock = local_mode_lock_fd.fileno()
data_path = os.path.join(DATA_DIR, 'mxnet_mnist')
script_path = os.path.join(data_path, 'mnist.py')

Expand All @@ -392,7 +393,13 @@ def test_local_transform_mxnet(sagemaker_local_session, tmpdir):
output_path = 'file://%s' % (str(tmpdir))
transformer = mx.transformer(1, 'local', assemble_with='Line', max_payload=1,
strategy='SingleRecord', output_path=output_path)

# Since Local Mode uses the same port for serving, we need a lock in order
# to allow concurrent test execution.
fcntl.lockf(local_mode_lock, fcntl.LOCK_EX)
transformer.transform(transform_input, content_type='text/csv', split_type='Line')
transformer.wait()
time.sleep(5)
fcntl.lockf(local_mode_lock, fcntl.LOCK_UN)

assert os.path.exists(os.path.join(str(tmpdir), 'data.csv.out'))