Fix bug in local mode #429
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #429 +/- ##
==========================================
+ Coverage 93.56% 93.71% +0.15%
==========================================
Files 55 55
Lines 4008 4010 +2
==========================================
+ Hits 3750 3758 +8
+ Misses 258 252 -6
Continue to review full report at Codecov.
|
laurenyu
previously approved these changes
Oct 12, 2018
laurenyu
approved these changes
Oct 15, 2018
pdasamzn
pushed a commit
to pdasamzn/sagemaker-python-sdk
that referenced
this pull request
Nov 1, 2018
* Fix bug in localmode Set correct default values for additional_env_vars and additional_volumes and add unit test. * Modify changelog
apacker
pushed a commit
to apacker/sagemaker-python-sdk
that referenced
this pull request
Nov 15, 2018
* Make pytorch notebooks compatible with pytorch preview. Add documentation on how to use it. * Use full framework version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #421 , if available:
Description of changes:
We had the default value flipped for additional_env_vars and additional_volumes. This change also adds a unit test for this code path.
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.